1680156 - Enable pages per sheet by default

Status: VERIFIED FIXED

(Toolkit :: Printing, task, P1)

Description

[Mark Striemer [:mstriemer]]

The pages per sheet feature is currently disabled while more sizes are supported (bug 1669905) and the margins are handled a bit better (bug 1670068).

Comment 1

[Daniel Holbert [:dholbert]]

As discussed in the print meeting: the more dataloss-ish bug (bug 1670068) has been fixed, and the other blocking bug doesn't feel like it needs to prevent us from enabling this on Nightly (and I should have it fixed soon), so I think we're going to go ahead enable the pref and get this some testing in Nightly, with bug 1669905's fix to follow soon.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1680156 - Enabled pages per sheet for early beta/nightly

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1680156 - Enable pages per sheet by default

Depends on D99158

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c9c2dcc306c
Enable pages per sheet by default r=emalysz

Comment 5

[Daniel Holbert [:dholbert]]

Hmm, the commit message and patch don't seem to agree.

The commit message says that it enables "pages-per-sheet" by default, but in fact that pref is still defaulting to false. It looks like the patch really changed the tab-modal printing pref to allow that to be enabled beyond the early-beta period.

(That's also something that's great to see, but that's probably a patch that wants to land on its own bug, right?)

Comment 6

[Daniel Holbert [:dholbert]]

(In phabricator you mention two patches - is there another patch still coming for the pages-per-sheet pref?) (never mind, I misunderstood)

Comment 7

[Mark Striemer [:mstriemer]]

Attachment: Bug 1680156 - Actually enable pages_per_sheet properly r?emalysz

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d77f557a129
Actually enable pages_per_sheet properly r=emalysz

Comment 9

[Mark Striemer [:mstriemer]]

There were two patches since I wasn't sure if we wanted to leave this as only early beta or enable it for when the print modal eventually rides the trains. So there was one patch for setting print.pages_per_sheet.enabled to @IS_EARLY_BETA_OR_EARLIER@ and one to make it true and unfortunately I messed up the true one and flipped the print.tab_modal.enabled pref instead :(

The second patch that's on inbound here reverts the print.tab_modal.enabled pref back to @IS_EARLY_BETA_OR_EARLIER@ and sets print.pages_per_sheet.enabled to true

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1c9c2dcc306c
https://hg.mozilla.org/mozilla-central/rev/7d77f557a129

Comment 11

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Confirming this a verified fixed on 86.0a1(20201218095607) and 85.0b3(20201217185930) with macOS 10.14.6, Win10x64 and Ubuntu 20.04