168017 - code living in mozilla/embedding/browser/cocoa/src is outdated.

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Arnaud Abrassart]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.14; Mac_PowerPC)
Build Identifier: all ?

since chimera got its own branch, code in 
mozilla/embedding/tests/cocoaEmbed doesn t compile.
the NSBrowserView.framework doesn t seem to be maintained.
We need to facilitate cocoa embedding of gecko.

Reproducible: Always

Steps to Reproduce:
1. ac_add_options --enable-default-toolkit=cocoa in .mozconfig
2. ./configure
3. make -f client.mk build
4. cd embedding/config
5. make

6. try and build 
mozilla/embedding/browser/cocoa/src/NSBrowserView.pbproj



Actual Results:  
NSBrowserView.mm:462: prototype for `nsresult 
nsCocoaBrowserListener::OnStateChange(nsIWebProgress *, 
nsIRequest *, int, unsigned int)' does not match any in class 
`nsCocoaBrowserListener'

Expected Results:  
build  NSBrowserView.framework

I ve started isolating a framework from chimera.pbproj.
Right now, the subset of chimera's code exported by my framework are:

BrowserWrapper.mm
CocoaPromptService.mm
nsAlertController.mm
SecurityDialogs.mm

nsDownloadListener.mm
ProgressDlgController.mm
SaveHeaderSniffer.mm

CHBrowserListener.mm
CHBrowserService.mm
CHBrowserView.mm
CHDownloadFactories.mm
CHDownloadProgressDisplay.mm

NSString+Utils.mm

FindDlgController.mm

As well as all libraries in the gecko group from chimera's PB file list. 
This is probably not the final set. It just so happens that it s the subset 
that seemed to require the less code changes to chimera.
I kinda expect people to tell me that only the CH* file belong in the 
embedding framework. Can anyone confirm this ?

My current goal is just to compile chimera with this framework, and then 
i can move things around (chimera <> NSBrowserView) a bit.
I ve problems locating dylibs in the framework at run time.
I m experimenting with the static build now.

I d like input from people involved in that area so that:
1) we ovoid duplicate work
2) i get assistance to check in changes so that this work does not need to 
be redone again on each new chimera branch.

BTW, should we rename NSBrowserView.pbproj to Cocoazilla.pbproj ?

Comment 1

[Mike Pinkerton (not reading bugmail)]

mine, going to work on this shortly

Comment 2

[Mike Pinkerton (not reading bugmail)]

much better now. up to date with latest in chimera.

note, you have to be on the branch.

Comment 3

[Mike Pinkerton (not reading bugmail)]

f.