1680194 - Remove mach's global arguments before starting Raptor

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

In bug 1487244 I added special casing for ./mach --debug-command however did not take care of the other global mach arguments...

$ ./mach raptor-test --help
usage: mach [global arguments] raptor-test [command arguments]

./mach --log-no-times raptor-test  --test=raptor-speedometer 
...
07:37:58     INFO -  raptor.py: error: unrecognized arguments: raptor-test
07:37:58    ERROR - Return code: 2

There was some discussion in bug 1487244 regarding how the munging of sys.argv wasn't the greatest approach but the consensus was that the effort to be perfect wasn't worth it.

I think an alternative to bug 1487244 is to remove all arguments from sys.argv which occur prior to the first occurrence of anything that begins with "raptor". This will handle all of mach's global arguments and is future proof should additional global arguments be added later.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1680194 - Do not pass global mach arguments to raptor, r=sparky.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c1692b94e34
Do not pass global mach arguments to raptor, r=sparky,perftest-reviewers.

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4c1692b94e34