[about:welcome] The Themes section on "Choose A Look" page is surrounded by a dotted line when a theme is selected
Categories
(Firefox :: Messaging System, defect, P2)
Tracking
()
People
(Reporter: obotisan, Assigned: emcminn)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [proton-onboarding] [priority:2a])
Attachments
(3 files)
Note
- The selected theme is already marked by a blue ring, which makes the dotted line that shows the whole section is selected redundant.
Affected versions
- Firefox 84.0b7-build1
- Firefoc 85.0a1
Affected platforms
- Ubuntu 16.04 x32
- Windows 8.1 x64
- Windows 7 x32
- Windows 10 x64 (aarch64)
Steps to reproduce
- Open Firefox and go to about:welcome.
- Navigate through the welcome screens to the "Choose A Look" screen.
- Select any random theme and then change it to another one.
Expected result
- The Themes section is not surrounded by a dotted line.
Actual result
- The Themes section is surrounded by a dotted line.
Regression range
- If this is a regression I will find it asap.
Suggested severity
- S4
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
Regression range
- First bad: 2020-07-29 (3059084abf6e9e96f9f1a80997da2139b0f5afee)
- Last good: 2020-07-28 (eba7e3ce93822075543bcc764cef7dbc8e9fc5f1)
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eba7e3ce93822075543bcc764cef7dbc8e9fc5f1&tochange=3059084abf6e9e96f9f1a80997da2139b0f5afee
- Potential regressor: bug 1653315
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
|
||
With the new circular theme choosers in proton, this focus rectangle becomes much more noticeable. Should this bug be triaged again?
Updated•3 years ago
|
Comment 3•3 years ago
|
||
AGreed it's pretty bad, marking as P2a (P1s are MR1 blockers) and adding proton tags so it gets picked on JIRA
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c8d08317d52 Adjust dotted border to match Proton styling r=Mardak
Updated•3 years ago
|
Comment 6•3 years ago
|
||
bugherder |
Reporter | ||
Comment 7•3 years ago
|
||
Verified the fix using latest Nightly 90.a1 on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64 there is still a line present. This appears when you hover on the section and disappears when he mouse is moved somewhere else.
However, if something is selected the line is still present even of the mouse is moved away.
Can you please tell me if this is expected behaviour?
Comment 8•3 years ago
|
||
Yes, previously the dotted line would stay visible when focus was within the area, and now it also shows the solid line on hover. If you click within, that ends up putting focus within.
Updated•3 years ago
|
Reporter | ||
Comment 9•3 years ago
|
||
Updated•3 years ago
|
Description
•