Closed Bug 1680215 Opened 3 years ago Closed 3 years ago

[about:welcome] The Themes section on "Choose A Look" page is surrounded by a dotted line when a theme is selected

Categories

(Firefox :: Messaging System, defect, P2)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: obotisan, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [proton-onboarding] [priority:2a])

Attachments

(3 files)

Note

  • The selected theme is already marked by a blue ring, which makes the dotted line that shows the whole section is selected redundant.

Affected versions

  • Firefox 84.0b7-build1
  • Firefoc 85.0a1

Affected platforms

  • Ubuntu 16.04 x32
  • Windows 8.1 x64
  • Windows 7 x32
  • Windows 10 x64 (aarch64)

Steps to reproduce

  1. Open Firefox and go to about:welcome.
  2. Navigate through the welcome screens to the "Choose A Look" screen.
  3. Select any random theme and then change it to another one.

Expected result

  • The Themes section is not surrounded by a dotted line.

Actual result

  • The Themes section is surrounded by a dotted line.

Regression range

  • If this is a regression I will find it asap.

Suggested severity

  • S4
Has Regression Range: --- → no
Has STR: --- → yes
Assignee: nobody → emcminn
Severity: -- → S4
Iteration: --- → 85.2 - Nov 30 - Dec 13
Priority: -- → P2

Regression range

Has Regression Range: no → yes
Keywords: regression
Type: enhancement → defect
Iteration: 85.2 - Nov 30 - Dec 13 → 86.1 - Jan 11 - Jan 24

With the new circular theme choosers in proton, this focus rectangle becomes much more noticeable. Should this bug be triaged again?

Flags: needinfo?(rtestard)
Flags: needinfo?(rtestard)
Whiteboard: [proton-onboarding] [priority:2a]

AGreed it's pretty bad, marking as P2a (P1s are MR1 blockers) and adding proton tags so it gets picked on JIRA

Priority: P2 → P1
Priority: P1 → P2
Status: NEW → ASSIGNED
Attachment #9220702 - Attachment description: WIP: Bug 1680215 - Adjust dotted border to match Proton styling → Bug 1680215 - Adjust dotted border to match Proton styling
Attachment #9220702 - Attachment description: Bug 1680215 - Adjust dotted border to match Proton styling → WIP: Bug 1680215 - Adjust dotted border to match Proton styling
Attachment #9220702 - Attachment description: WIP: Bug 1680215 - Adjust dotted border to match Proton styling → Bug 1680215 - Adjust dotted border to match Proton styling
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c8d08317d52
Adjust dotted border to match Proton styling r=Mardak
Iteration: 86.1 - Dec 14 - Dec 27 → 90.2 - May 3 - May 16
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Verified the fix using latest Nightly 90.a1 on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64 there is still a line present. This appears when you hover on the section and disappears when he mouse is moved somewhere else.
However, if something is selected the line is still present even of the mouse is moved away.

Can you please tell me if this is expected behaviour?

Flags: needinfo?(emcminn)

Yes, previously the dotted line would stay visible when focus was within the area, and now it also shows the solid line on hover. If you click within, that ends up putting focus within.

Flags: needinfo?(emcminn)

According to comment 7 and comment 8 I will mark this bug as verified fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: