1680230 - Update rkv to 0.16.0

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

We need to upgrade rkv, then land that update in m-c in coordination with other users of rkv.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1355

Comment 2

[Victor Porof [:vporof][:vp]]

What's the process? Update glean, publish it to crates, then update rkv and glean together in m-c?

Comment 3

[Jan-Erik Rediger [:janerik]]

Yup, though we're landing another big Glean update right now, so that needs to happen first.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1680230 - Part 1: Update rkv to 0.16.0, r=janerik

Depends on D98482

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1680230 - Part 2: Vendor, r=janerik

Depends on D98594

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ced955ab891
Part 1: Update rkv to 0.16.0, r=janerik
https://hg.mozilla.org/integration/autoland/rev/804ccdf33ae8
Part 2: Vendor, r=janerik

Comment 7

[Alexandru Michis [:malexandru]]

Backed out 5 changesets (Bug 1654192, Bug 1680230) for causing tsan bc failures in RWLock.

Backout link: https://hg.mozilla.org/integration/autoland/rev/821f3a55cb71c53d361d962c5060c972ef34e52b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=e090b0e10f5de9c444d145caeff7b166fbc17736&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt&tochange=821f3a55cb71c53d361d962c5060c972ef34e52b&selectedTaskRun=FaBgyqyeS3iSb_SuxyUJ6Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=323742182&repo=autoland&lineNumber=2293

Comment 8

[Jan-Erik Rediger [:janerik]]

We should have made its own bug for the code you're landing, :vporof. Renaming this bug.
We can keep it here for now, but in the future we should probably track these separately.

Comment 9

[Victor Porof [:vporof][:vp]]

It's a little bit the other way around – the tsan failure is very likely caused by updating to 0.16, which is an issue that I'm looking into fixing right now. I agree with renaming this bug.

Comment 10

[Jan-Erik Rediger [:janerik]]

Unfortunately the lock-order-inversion failure seems to be in FOG code.
We might have just been unlucky to find it here.

Comment 11

[Jan-Erik Rediger [:janerik]]

Talked to Victor in private.
It looks like by upgrading we resurfaced a false-positive (bug 1606804) due the to the change in paths for only Glean/FOG (because we duplicate rkv versions).

A Glean upgrade is coming today or tomorrow also upgrading its rkv dependency, that should fix this without requiring yet another exception for TSAN (as done here: https://searchfox.org/mozilla-central/rev/c14733e74e540b71856cc1d963bc424b38aa4bef/mozglue/build/TsanOptions.cpp#101-102)

Taking over the bug to get that update in.

Comment 12

[Victor Porof [:vporof][:vp]]

Thanks Jan-Erik!

Comment 13

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1680230 - Update Glean to 33.7.0. r?dexter!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02dced2018db
Part 1: Update rkv to 0.16.0, r=janerik
https://hg.mozilla.org/integration/autoland/rev/2e99b5099cb5
Part 2: Vendor, r=janerik
https://hg.mozilla.org/integration/autoland/rev/55d02702cb10
Update Glean to 33.7.0. r=Dexter

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/02dced2018db
https://hg.mozilla.org/mozilla-central/rev/2e99b5099cb5
https://hg.mozilla.org/mozilla-central/rev/55d02702cb10