1680277 - VoiceOver does not identify hyperlinks in contentEditables

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Marco Zehe (:MarcoZ)]

Steps:

1. Open data:text/html,<div contentEditable="true" tabindex="0" role="textbox" aria-multiline="true"><p>This is a paragraph with a <a href="https://mozilla.org">hyperlink</a> in it.</p></div>.
2. Explore the text with VoiceOver.
   • Expected: The word "hyperlink" should be indicated to be a link.
   • actual: VoiceOver treats it as normal text along with all the other text.

This works as expected in Safari and Chrome.

Impact: This makes it impossible in Google Docs to identify hyperlinks in documents.

Comment 1

[Eitan Isaacson [:eeejay]]

To fix this we would need to implement attributed strings. I think it is too late in the cycle for that at the moment. I can start working on this and have something ready for early next cycle (86).

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1680277 - 1/3: Add editable and focusable ancestor getters. r?morgan!

For focusable ancestor, just use editable ancestor since the IPC toll
on finding closest focusable ancestor isn't worth it.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1680277 - 2/3: Use previous offset for calculating element at marker. r?morgan!

This is consistent with how WebKit does it: if offset is between two accessibles,
return the previous one.

Depends on D99311

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1680277 - 3/3: Use AXTextArea for multiline and aria text boxes. r?morgan!

By spec, it would need to be an area for aria-multiline=true and a field for aria-multiline=false. Chrome seems to assign all aria text boxes to areas. For some reason this allows VO to recognize links when editing. Webkit doesn't need this, for some reason and can get links announces in AXTextField as well.

Depends on D99312

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bbfaf673d39
1/3: Add editable and focusable ancestor getters. r=morgan
https://hg.mozilla.org/integration/autoland/rev/bb00472c7a1f
2/3: Use use previous offset for calculating element at marker. r=morgan
https://hg.mozilla.org/integration/autoland/rev/4ad2bcdda94c
3/3: Use AXTextArea for multiline and aria text boxes. r=morgan

Comment 6

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1680277) for Browser-chrome failures in browser/mac/browser_rotor.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=324203757&repo=autoland&lineNumber=1706

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4ad2bcdda94cb91b3c34d66cb8e250a00dcfaeaa

Backout:
https://hg.mozilla.org/integration/autoland/rev/ecee883c23e31c1f0c6d9846dd2bca7c6153c1a8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d02c802aa04d
1/3: Add editable and focusable ancestor getters. r=morgan
https://hg.mozilla.org/integration/autoland/rev/0023aff32a75
2/3: Use previous offset for calculating element at marker. r=morgan
https://hg.mozilla.org/integration/autoland/rev/12c70651cd77
3/3: Use AXTextArea for multiline and aria text boxes. r=morgan,MarcoZ

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d02c802aa04d
https://hg.mozilla.org/mozilla-central/rev/0023aff32a75
https://hg.mozilla.org/mozilla-central/rev/12c70651cd77