Closed Bug 1680345 Opened 7 months ago Closed 7 months ago

Require six 1.13.0 in non third_party and non web-platform packages

Categories

(Testing :: General, task)

Default
task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: bc, Assigned: bc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Most of the python requirements for six in tree specify version 1.10.0. However we currently have uses of six.ensure_binary, six.ensure_text and six.ensure_str in tree which were not added until six 1.12.0.

If we are going to bump the minimum version of six, we might as well go for the latest version 1.15.0 which will also provides optimized versions of the ensure_* methods.

I'm planning on ignoring third_party code in tree.

jgraham: wptserve has six >= 1.8 testing/web-platform/tests/tools/wptserve/setup.py:deps = ["six>=1.8", "h2==3.0.1"]. Is this something I could change or does it need additional steps to update upstream?

Flags: needinfo?(james)

oops. wrong summary! fixed.

Summary: Require six 1.13.0 in non third_party and non web-platform packages → Require six 1.15.0 in non third_party and non web-platform packages

Adding six 1.15.0 is too problematic so we'll stick with six 1.13.0 that is already in pypi.pub.build.mozilla.org/pub/

Summary: Require six 1.15.0 in non third_party and non web-platform packages → Require six 1.13.0 in non third_party and non web-platform packages

You can change wptserve; the sync should automatically handle upstreaming the change.

Flags: needinfo?(james)
Assignee: nobody → bob
Status: NEW → ASSIGNED
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee2fd8e8a5c8
python3 - Require six 1.13.0 in non third_party and non web-platform packages r=jgraham,jmaher
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26750 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.