1680345 - Require six 1.13.0 in non third_party and non web-platform packages

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Bob Clary [:bc] (inactive)]

Most of the python requirements for six in tree specify version 1.10.0. However we currently have uses of six.ensure_binary, six.ensure_text and six.ensure_str in tree which were not added until six 1.12.0.

If we are going to bump the minimum version of six, we might as well go for the latest version 1.15.0 which will also provides optimized versions of the ensure_* methods.

I'm planning on ignoring third_party code in tree.

jgraham: wptserve has six >= 1.8 testing/web-platform/tests/tools/wptserve/setup.py:deps = ["six>=1.8", "h2==3.0.1"]. Is this something I could change or does it need additional steps to update upstream?

Comment 1

[Bob Clary [:bc] (inactive)]

oops. wrong summary! fixed.

Comment 2

[Bob Clary [:bc] (inactive)]

Adding six 1.15.0 is too problematic so we'll stick with six 1.13.0 that is already in pypi.pub.build.mozilla.org/pub/

Comment 3

[James Graham [:jgraham]]

You can change wptserve; the sync should automatically handle upstreaming the change.

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1680345 - python3 - Require six 1.13.0 in non third_party and non web-platform packages

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee2fd8e8a5c8
python3 - Require six 1.13.0 in non third_party and non web-platform packages r=jgraham,jmaher

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26750 for changes under testing/web-platform/tests

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ee2fd8e8a5c8

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot