1680432 - Wrong text color of folder when receiving new message and the focus moves somewhere else

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2020-12-02 at 10.30.08 PM.png

This happens only on macOS, and it presents itself right after receiving a new message and the focus moves somewhere else.
The folder text color turns white, which doesn't really work well with the light grey background.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1680432-mac-folderPane-no-highlight-color.patch

We don't need the HighlightText as macOS has no Highlight background treechildren when selected.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9191136 [details] [diff] [review]
1680432-mac-folderPane-no-highlight-color.patch

Review of attachment 9191136 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/56fcc344e49e
Mac default theme: Don't use the highlight text color for selected folders with new messages. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9191136 [details] [diff] [review]
1680432-mac-folderPane-no-highlight-color.patch

[Approval Request Comment]
User impact if declined: only Mac, low contrast when folder with new message is selected on default theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9191136 [details] [diff] [review]
1680432-mac-folderPane-no-highlight-color.patch

[Triage Comment]
Approved for esr78
(no beta uplift, so this will be in beta 85)

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/96c4425e6eb5