Closed Bug 1680434 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26736 - Support WebBundle Subresource loading via Network Service

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26736 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26736
Details from upstream follow.

b'Hayato Ito <hayato@chromium.org>' wrote:

Support WebBundle Subresource loading via Network Service

This is a follow-up to https://crrev.com/c/2560526.

This CL changes the implementation of WebBundle subresource loading
from "renderer oriented" to "network service oriented".

Before this CL, a renderer parses a WebBundle and serves a subresource
from there directly.

After this CL, they are done in the Network Service, instead of a renderer.

The motivation we're changing our design is "we should honor CORB
1". A renderer shouldn't have cross-origin data in their memory.
See the design doc 2 for details.

Note this CL removes
blink/renderer/platform/loader/fetch/url_loader/web_bundle_subresource_loader_test.cc,
which was already moved to
services/network/web_bundle_url_loader_factory_unittest.cc in a previous CL.

Bug: 1082020
Change-Id: I78b0e81b573f735c84334a4cd2271c248609c2e8
Reviewed-on: https://chromium-review.googlesource.com/2564924
WPT-Export-Revision: 01ce6815eca80ed21d28e15bd045c7c8d95996af

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 2

Chrome

FAIL : 1
TIMEOUT: 2

Safari

FAIL : 1
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-bundle/subresource-loading/subresource-loading-nested-bundle.tentative.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
A nested bundle can be fetched: FAIL (Chrome: FAIL, Safari: FAIL)
Subresources in a nested bundle should not be loaded: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

/web-bundle/subresource-loading/subresource-loading-nested-bundle.tentative.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b439b0edebe5
[wpt PR 26736] - Support WebBundle Subresource loading via Network Service, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.