Closed Bug 1680468 Opened 4 years ago Closed 4 years ago

Mails with invalid vcard attached not marked as read in preview

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect

Tracking

(thunderbird_esr78+ fixed, thunderbird85 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird85 --- fixed

People

(Reporter: pawel, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Mails from one user are not marked as read - even when I open them with double click. I can only mark them manually.
All mails are marked as read despite ones from one user:
In message source:
From: =?UTF-8?Q?Monika_Mierzy=c5=84ska_-_Kaczmarek?= <mkaczmarek@spnt.pl>

Actual results:

Mails from:
From: =?UTF-8?Q?Monika_Mierzy=c5=84ska_-_Kaczmarek?= <mkaczmarek@spnt.pl>

Are not marked as read (only manually). It happens in every Thunderbird in my company.

Expected results:

Mails from
From: =?UTF-8?Q?Monika_Mierzy=c5=84ska_-_Kaczmarek?= <mkaczmarek@spnt.pl>

Ares supposed to act as other ones - be marked as read after seing in preview or opened.

Thomas, can you create a sample message and test.

Flags: needinfo?(bugzilla2007)

(In reply to Magnus Melin [:mkmelin] from comment #1)

Thomas, can you create a sample message and test.

Sure, had done that already when this was filed but somehow the comment didn't get into BMO.

This wfm on Win10, 78.5.1 (64-bit), auto-marked read, marks read on opening etc., all normal.
I don't think this behaviour could be cause by the sender's name.
Maybe something else in the message source of this or surrounding messages which affects the message.

Reporter, can you save an affected message as .eml and send that file via email to me (bugzilla2007...)?

Flags: needinfo?(bugzilla2007) → needinfo?(pawel)
Flags: needinfo?(pawel)

Thanks, I can see how this goes wrong. There's an invalid vcard attached (literally "null", base64 encoded) so we end up at https://searchfox.org/comm-central/rev/a18b84093ce824cd90f76054da6885378bc390c8/calendar/base/modules/Ical.jsm#1969

Assignee: nobody → mkmelin+mozilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Regressed by: 1639430
Summary: Mails from one user not marked as read in preview → Mails with invalid vcard attached not marked as read in preview
Attachment #9192279 - Attachment is obsolete: true
Attachment #9192573 - Flags: review?(geoff)
Status: NEW → ASSIGNED
Target Milestone: --- → 85 Branch
Comment on attachment 9192573 [details] [diff] [review] bug1680468_card_markread.patch Review of attachment 9192573 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/test/browser/folder-display/data/test-invalid-vcard.eml @@ +14,5 @@ > +has an attached vcf which has invalid data (null) > + > +--------------B16B2089EF5F4ADD84A4E66F > +Content-Type: text/x-vcard; > + name="conentisnull.vcf" content? @@ +17,5 @@ > +Content-Type: text/x-vcard; > + name="conentisnull.vcf" > +Content-Transfer-Encoding: base64 > +Content-Disposition: attachment; > + filename="onentisnull.vcf" And here.

Comment on attachment 9192573 [details] [diff] [review]
bug1680468_card_markread.patch

LGTM but I think we should combine this test somehow with message-window/browser_vcardActions.js. At least add tags = vcard to it in the manifest. And the typos as already mentioned.

Attachment #9192573 - Flags: review?(geoff) → review+

Putting it in browser_vcardActions.js was my first thought, but then I realized that tests mails that are standalone. This test needs them to be in a folder, and surprisingly I didn't find we have any existing test where we check behaviour of test case .emls in the folder pane.

What does adding tags = vcard do?

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4741f42c851f
Mails containing invalid vcards not marked as read in preview. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: 85 Branch → 86 Branch

Comment on attachment 9192573 [details] [diff] [review]
bug1680468_card_markread.patch

[Approval Request Comment]
Regression caused by (bug #): ab work for 78
User impact if declined: messages may not be automatically marked as read
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): has test and well understood, not risky

Attachment #9192573 - Flags: approval-comm-esr78?
Attachment #9192573 - Flags: approval-comm-beta?

Comment on attachment 9192573 [details] [diff] [review]
bug1680468_card_markread.patch

[Triage Comment]
Approved for beta

Attachment #9192573 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9192573 [details] [diff] [review]
bug1680468_card_markread.patch

[Triage Comment]
Approved for esr78

Attachment #9192573 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: