1680653 - If the default account is removed, and no other account can be default, defaultAccount still points to the removed account

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Geoff Lankow (:darktrojan)]

On account removal, if the account being removed is the default, AutosetDefaultAccount is called. But if no account can be the default, the old value remains.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1680653 - Clear the default account if it is removed and no other account can be default. r?mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40a369a5a82d
Clear the default account if it is removed and no other account can be default. r=mkmelin

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9191212 [details]
Bug 1680653 - Clear the default account if it is removed and no other account can be default. r?mkmelin

[Approval Request Comment]
User impact if declined:
In general: Add-on developers can not use the latest fixes and improvements of our WebExtension API.
Specifically this bug: The test for bug 1658132 (which is an API fix) needs this bug to be uplifted as well.

Testing completed (on c-c, etc.):
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=3cdff293d5d1bd77777f5da371caaa02c4b05de3

Risk to taking this patch (and alternatives if risky):
I hope none

Remark:
The provided try run includes all bugs I want to uplift for TB 78.7 and shows a working patch order.
This bug (1680653) is the first one, who does not have a bug number in the commit message.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9191212 [details]
Bug 1680653 - Clear the default account if it is removed and no other account can be default. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 5

[Dave Miller [:justdave]]

Thunderbird 78.7.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6a39257a736f