Invitation details dialog toolbar not correctly themed with LW-themes
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: rjhansen075, Assigned: Paenglab)
References
Details
Attachments
(8 files, 3 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0
Steps to reproduce:
Install a persona with light icons. In this case, I chose "Dark Blue." Go from default theme to installed persona theme.
Actual results:
Though the theme installs and views properly, other dialogues now have light toolbar icons, which make the toolbar hard to read.
Expected results:
Toolbars in dialogues should be unaffected/be colored in a way that is legible.
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
Reporter | ||
Comment 3•4 years ago
|
||
Oddly enough, the Dark Blue theme does not show light icons as it's chosen toolbar color. They are supposed to be dark blue like the header bar. I'm not sure why Thunderbird isn't honoring the persona's icon color choice, and this may be a bug in and of itself in personas.
If any theme with light toolbar icons is used, the dialog box toolbar will be affected.
Reporter | ||
Comment 4•4 years ago
|
||
On second thought, the problem seems to be that the Personas manager is not honoring the toolbar icon color of the theme. I've tried a variety of themes like "Dark Blue," and I can't seem to find one that has light colored toolbar icons. Yet they all show light toolbar icons.
It looks like there was some change from 68 that caused Thunderbird to stop honoring persona color choices, and choose dark mode icons, which don't work with the dialog because the theme is not actually in dark mode, so the toolbar background is light.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 5•4 years ago
|
||
Confirmed: Thunderbird is choosing dark mode icons (based on theme colors?), not on the actual persona theme choice. As a result, non dark mode themes will have icon colors for dark mode, which screws up dialogs.
Please try to reproduce. Thanks.
Reporter | ||
Comment 6•4 years ago
|
||
This is how it is handled in 68.12.1.
It still chooses light icons for the toolbar, but uses default mode toolbar icons for the dialog.
Comment hidden (obsolete) |
Reporter | ||
Comment 8•4 years ago
|
||
This is how it is handled in 68.12.1.
It still chooses light icons for the toolbar, but uses default mode toolbar icons for the dialog.
Reporter | ||
Comment 9•4 years ago
|
||
Note that 68 still chooses to not honor the toolbar icon color of the theme.
There are a variety of things happening with Personas here.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 10•4 years ago
|
||
Sorry about the messy report. I got ideas for testing after it was already filed.
Updated•4 years ago
|
Assignee | ||
Comment 11•4 years ago
|
||
Do you see other dialogs behaving like this too or is this the only dialog?
Reporter | ||
Comment 12•4 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #11)
Do you see other dialogs behaving like this too or is this the only dialog?
By no means do I know where every dialog with a toolbar is in Thunderbird, but all the other dialogs appear to respect the toolbar color of the persona. So, for Dark Blue, it becomes off-white text on a slate background which is usable.
Reporter | ||
Comment 13•4 years ago
|
||
For instance: This is the dialog for entering a task in Lightning.
It seems to be limited to the event accept/decline toolbar. If you could give me an exhaustive list of all dialogs that use toolbars in this way, I can test all of them.
Assignee | ||
Updated•4 years ago
|
Comment 14•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 15•4 years ago
|
||
You need to test this with a LW-theme. The normal dark and light themes worked already.
Reporter | ||
Comment 16•4 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #15)
Created attachment 9191485 [details] [diff] [review]
1680755-details-dialog-themeable.patchYou need to test this with a LW-theme. The normal dark and light themes worked already.
The "Dark Blue" theme definitely triggers the problem if you want a test case.
https://addons.thunderbird.net/en-US/thunderbird/addon/dark-blue/?src=search
Comment 17•4 years ago
|
||
Comment 18•4 years ago
|
||
Assignee | ||
Comment 19•4 years ago
|
||
Using now a dashed focus-ring and hide the complete toolbox in a normal summary dialog.
Comment 20•4 years ago
|
||
Assignee | ||
Comment 21•4 years ago
|
||
Moved the focus ring code to notification.css.
Assignee | ||
Updated•4 years ago
|
Comment 22•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/01f070944725
Make the invitation details dialog toolbar correctly themeable. r=aleca
Updated•4 years ago
|
Description
•