Closed Bug 1680755 Opened 4 years ago Closed 4 years ago

Invitation details dialog toolbar not correctly themed with LW-themes

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: rjhansen075, Assigned: Paenglab)

References

Details

Attachments

(8 files, 3 obsolete files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Install a persona with light icons. In this case, I chose "Dark Blue." Go from default theme to installed persona theme.

Actual results:

Though the theme installs and views properly, other dialogues now have light toolbar icons, which make the toolbar hard to read.

Expected results:

Toolbars in dialogues should be unaffected/be colored in a way that is legible.

Attached image Persona toolbar
Attached image Persona information

Oddly enough, the Dark Blue theme does not show light icons as it's chosen toolbar color. They are supposed to be dark blue like the header bar. I'm not sure why Thunderbird isn't honoring the persona's icon color choice, and this may be a bug in and of itself in personas.

If any theme with light toolbar icons is used, the dialog box toolbar will be affected.

On second thought, the problem seems to be that the Personas manager is not honoring the toolbar icon color of the theme. I've tried a variety of themes like "Dark Blue," and I can't seem to find one that has light colored toolbar icons. Yet they all show light toolbar icons.

It looks like there was some change from 68 that caused Thunderbird to stop honoring persona color choices, and choose dark mode icons, which don't work with the dialog because the theme is not actually in dark mode, so the toolbar background is light.

Summary: Undesirable side effects when persona theme chooses light toolbar icons → Undesirable side effects when Thunderbird doesn't honor persona theme toolbar icon color choice

Confirmed: Thunderbird is choosing dark mode icons (based on theme colors?), not on the actual persona theme choice. As a result, non dark mode themes will have icon colors for dark mode, which screws up dialogs.

Please try to reproduce. Thanks.

Attached file Delete me please (obsolete) (deleted) —

This is how it is handled in 68.12.1.

It still chooses light icons for the toolbar, but uses default mode toolbar icons for the dialog.

Attached image Dialog box in 68.12.1

This is how it is handled in 68.12.1.

It still chooses light icons for the toolbar, but uses default mode toolbar icons for the dialog.

Attached image Toolbar 68.12.1

Note that 68 still chooses to not honor the toolbar icon color of the theme.

There are a variety of things happening with Personas here.

Attachment #9191306 - Attachment description: Dialog Thunderbird 68.12.1 → Delete me please

Sorry about the messy report. I got ideas for testing after it was already filed.

Attachment #9191306 - Attachment filename: Screenshot 2020-12-04 091534.jpg → Screenshot 2020-12-04 091534.txt
Attachment #9191306 - Attachment is obsolete: true
Attachment #9191306 - Attachment mime type: image/jpeg → text/plain

Do you see other dialogs behaving like this too or is this the only dialog?

Flags: needinfo?(rjhansen075)

(In reply to Richard Marti (:Paenglab) from comment #11)

Do you see other dialogs behaving like this too or is this the only dialog?

By no means do I know where every dialog with a toolbar is in Thunderbird, but all the other dialogs appear to respect the toolbar color of the persona. So, for Dark Blue, it becomes off-white text on a slate background which is usable.

Flags: needinfo?(rjhansen075)
Attached image Task List Entry dialog

For instance: This is the dialog for entering a task in Lightning.

It seems to be limited to the event accept/decline toolbar. If you could give me an exhaustive list of all dialogs that use toolbars in this way, I can test all of them.

Summary: Undesirable side effects when Thunderbird doesn't honor persona theme toolbar icon color choice → Invitation details dialog toolbar not correctly themed with LW-themes
The content of attachment 9191306 [details] has been deleted for the following reason: Deleted at request of author
Component: Untriaged → Theme

You need to test this with a LW-theme. The normal dark and light themes worked already.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9191485 - Flags: review?(alessandro)

(In reply to Richard Marti (:Paenglab) from comment #15)

Created attachment 9191485 [details] [diff] [review]
1680755-details-dialog-themeable.patch

You need to test this with a LW-theme. The normal dark and light themes worked already.

The "Dark Blue" theme definitely triggers the problem if you want a test case.

https://addons.thunderbird.net/en-US/thunderbird/addon/dark-blue/?src=search

Comment on attachment 9191485 [details] [diff] [review] 1680755-details-dialog-themeable.patch Review of attachment 9191485 [details] [diff] [review]: ----------------------------------------------------------------- Good work on this as it makes it readable and follow the theme. A couple of issues still noticeable that I think we should fix. The toolbar has a thick border bottom, coming from an :after pseudo element that doesn't follow the background color, looking out of place and noticeable even for regular summaries without invitation. The visible focus ring of the close notification image makes it look like the notification bar is cut. (screenshot coming)
Attachment #9191485 - Flags: review?(alessandro) → feedback+
Blocks: 1679788

Using now a dashed focus-ring and hide the complete toolbox in a normal summary dialog.

Attachment #9191485 - Attachment is obsolete: true
Attachment #9191735 - Flags: review?(alessandro)
Comment on attachment 9191735 [details] [diff] [review] 1680755-details-dialog-themeable.patch Review of attachment 9191735 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/base/content/dialogs/calendar-summary-dialog.css @@ +18,5 @@ > + > +.messageCloseButton:-moz-focusring > .toolbarbutton-icon { > + outline: 1px dashed; > + outline-offset: -2px; > +} I think this should be in the shared messenger.css file in order to be sure all the notifications across Thunderbird will use this style for consistency.
Attachment #9191735 - Flags: review?(alessandro) → review+

Moved the focus ring code to notification.css.

Attachment #9191735 - Attachment is obsolete: true
Attachment #9191828 - Flags: review+
Target Milestone: --- → 85 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/01f070944725
Make the invitation details dialog toolbar correctly themeable. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: