Closed Bug 1680769 Opened 3 years ago Closed 3 years ago

2.96 - 7.43% tp5o / tresize (linux64-shippable-qr, macosx1014-64-shippable-qr) regression on push 7051f98f3fb01e1b0502d769d111c612a29125e5 (Tue December 1 2020)

Categories

(Core :: Graphics: WebRender, defect)

Firefox 85
defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: alexandrui, Assigned: nical)

References

(Regression)

Details

(4 keywords)

Attachments

(3 files)

Perfherder has detected a talos performance regression from push 7051f98f3fb01e1b0502d769d111c612a29125e5. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
7% tp5o macosx1014-64-shippable-qr e10s stylo webrender 329.18 -> 353.65
6% tresize linux64-shippable-qr e10s stylo webrender 15.12 -> 16.01
5% tresize linux64-shippable-qr e10s stylo webrender 15.19 -> 15.94
3% tp5o linux64-shippable-qr e10s stylo webrender 219.67 -> 226.16

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(nical.bugzilla)
Component: Performance → Graphics: WebRender
Product: Testing → Core

These patches weren't intending to change the behavior so it shouldn't be too hard to figure this out.

Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1ad5c9b8c33
Fix the texture cache allocating rectangles multiple times (again). r=jnicol
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Flags: needinfo?(aionescu)

Nicolas, the graph doesn't seem like returned.

Status: RESOLVED → REOPENED
Flags: needinfo?(aionescu)
Resolution: FIXED → ---
Flags: needinfo?(nical.bugzilla)

Odd. Bisection on try points to https://phabricator.services.mozilla.com/D98202 which does very little other than introduce the regression fixed by https://hg.mozilla.org/mozilla-central/rev/f1ad5c9b8c33 and move code from a file to another one.

I'm trying a few things.

Flags: needinfo?(nical.bugzilla)

== Change summary for alert #28044 (as of Thu, 10 Dec 2020 12:53:20 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
6% Resident Memory macosx1014-64-shippable-qr 743,031,756.53 -> 701,161,447.35
5% Heap Unclassified linux1804-64-shippable-qr tp6 280,741,979.06 -> 265,655,207.80
4% Heap Unclassified linux1804-64-shippable-qr tp6 278,461,077.24 -> 266,251,974.12
3% Explicit Memory linux1804-64-shippable-qr tp6 695,073,978.67 -> 675,998,986.52

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28044

When deallocating the last item of the region the region's size is changed in free and we end up returning the wrong value.
The faulty code is actually removed in a later patch from this series but I'd like to fix the regressing now and land the patch that removes the bad code during the next train.

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11ffdf919a4a
Fix incorrect returned size in some cases. r=jnicol
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED

(In reply to Pulsebot from comment #10)

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11ffdf919a4a
Fix incorrect returned size in some cases. r=jnicol

== Change summary for alert #28068 (as of Mon, 14 Dec 2020 00:04:57 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
8% tp5o_webext macosx1014-64-shippable-qr e10s stylo webrender 482.70 -> 441.84
6% tresize linux64-shippable-qr e10s stylo webrender 15.79 -> 14.89
6% tp5o_scroll linux64-shippable-qr e10s stylo webrender 2.76 -> 2.61
5% tp5o linux64-shippable-qr e10s stylo webrender 226.00 -> 214.77
5% tp5o_webext linux64-shippable-qr e10s stylo webrender 290.34 -> 276.28

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28068

Regressions: 1682562
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: