Closed Bug 16808 Opened 26 years ago Closed 26 years ago

view-source doesn't show source when charset in meta element

Categories

(Core :: DOM: HTML Parser, defect, P3)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: dbaron, Assigned: rickg)

References

Details

(Whiteboard: fix in local tree. Need review and M12 tree open)

DESCRIPTION: View source is showing the page rather than the source in today's build. In the build from 2 days ago (the 17th), it didn't show anything. STEPS TO REPRODUCE: * start apprunner * load a page * Do View | Page Source ACTUAL RESULTS: * the page EXPECTED RESULTS: * the source DOES NOT WORK CORRECTLY ON: * Linux, apprunner, 1999-10-19-08-M11
I see viewsource perfectly in apprunner and viewer with today's linux build. Perhaps your html.css is bad?
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Still not working for me, in Linux apprunner 1999102011. I unzipped the build and ran it, so it can't be html.css. It could be something peculiar in my prefs, though, or something. However, view-source should still work... I'm reopening this, and I'll investigate more on the weekend.
Resolution: WORKSFORME → ---
Summary: view-source doesn't show source... → view-source doesn't show source for some pages
OK... it's only happening on some pages. When I filed the bug, I tried two or three, but maybe they were all my own pages. I suspect it has something to do with the stylesheet linking. For example: http://www.fas.harvard.edu/~dbaron/
Summary: view-source doesn't show source for some pages → view-source doesn't show source when charset in meta element
Well, I changed my first guess the minute I looked at the page, and my new first guess was right. The trigger is: <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> That doesn't surprise me, because that makes the page begin some part of the loading process over again.
Assignee: rickg → ftang
Status: REOPENED → NEW
After discussing with Frank Tang, the problem appears to be that XML documents are not handling charset detection. He plans to add support for that.
Status: NEW → ASSIGNED
Target Milestone: M12
View Source are now implemented as XML document. We need to copy some logic from nsHTMLDocument.cpp into nsXMLDocument.cpp
*** Bug 17105 has been marked as a duplicate of this bug. ***
Hardware: PC → All
Hardware: All → PC
patch is available in http://warp/u/ftang/viewsource16808.txt Need waterson to review it and wait till tree open for M12 to check in.
Whiteboard: fix in local tree. Need review and M12 tree open
It should be http://warp/u/ftang/tmp/viewsource16808.txt not http://warp/u/ftang/ viewsource16808.txt
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
fix check into M12 tip.
Status: RESOLVED → REOPENED
This is not working in Linux mozilla 1999-11-20-08-M12. Reopening.
*** Bug 19041 has been marked as a duplicate of this bug. ***
Resolution: FIXED → ---
Depends on: 19206
The linux is broken because bug 19206
Assignee: ftang → harishd
Status: REOPENED → NEW
reassign to harishd since he own 19206. This bug should be fixed when you fix bug 19206.
*** Bug 19285 has been marked as a duplicate of this bug. ***
Assignee: harishd → petersen
I think this may be fixed now, since the dependency bugs are fixed. Chris, can you confirm?
Which version of Moz has it been fixed in? I have 1999120208 WinNT 4 and I can't even display the source of Yahoo....
That's an entirely separate bug. Yahoo doesn't have a charset in a meta element. Could you please file a separate bug and note the bug number here? (Or maybe I will, sometime...)
Assignee: petersen → rickg
I'm not seeing this original problem on the the latest Linux build (1999121508). Page source is only displaying html code in it's window.
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
I dont see this problem either. Let's mark this one fixed. If viewsource breaks again, we'll reopen a new bug on that.
updated qa contact.
QA Contact: janc → bsharma
Verified on: build: 2001-04-02-09-Mtrunk platform: WinNT View source opens the source in its own window.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.