Closed Bug 1680813 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26760 - Fail gracefully if |parameter| object has an invalid array topology

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26760 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26760
Details from upstream follow.

b'Hongchan Choi <hongchan@chromium.org>' wrote:

Fail gracefully if |parameter| object has an invalid array topology

AudioWorkletProcessor::CopyParamValueMapToObject() assumed the array
topology is always valid (DCHECK), but if the user code actively mangles
the parameter descriptor getter the array to return invalid content
this assumption becomes invalid.

The fix is to fail gracefully when the object type or the array content
is not correct.

Bug: 1151069
Test: The repro case does not reproduce any more after 1 hour run.
Change-Id: I3f8decd3721e9b00ba201e2f76751e4bc941e05d
Reviewed-on: https://chromium-review.googlesource.com/2569788
WPT-Export-Revision: 87896b9e1321440c04546c792446d54aa3294cb2

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
PASS: 7
FAIL: 3

Chrome

OK : 1
PASS: 7
FAIL: 3

Safari

OK : 1
PASS: 7
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-param-getter-overridden.https.html
X The rendered buffer: Expected 0 for all values but found 128 unexpected values:
Index Actual
[0] 1
[1] 1
[2] 1
[3] 1
...and 124 more errors.: FAIL (Chrome: FAIL, Safari: FAIL)
< [Verifying AudioParam in AudioWorkletNode] 1 out of 1 assertions were failed.: FAIL (Chrome: FAIL, Safari: FAIL)

AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/461354a0dc15
[wpt PR 26760] - Fail gracefully if |parameter| object has an invalid array topology, a=testonly
https://hg.mozilla.org/integration/autoland/rev/fcbe7622e912
[wpt PR 26760] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.