1680840 - Firefox with Voice Over freezes when changing rotor rule while navigating inside the table.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

STR's:

• got to about:config
• expand all preferences
• navigate into any arbitrary cell (current value for example)
• I used VO + command + left/right arrow to change the rotor rule to get this stack

Observed:
Firefox freezes for tens of seconds, though then the rotor rule changes.

Profiler link (it's huge and might not load).

Inverted stack from the profiler:

(root)
start
main
XRE_main(int, char**, mozilla::BootstrapConfig const&)
XREMain::XRE_main
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&)
XREMain::XRE_mainRun()
nsAppStartup::Run()
nsAppShell::Run()
-[NSApplication run]
-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
_DPSNextEvent
_BlockUntilNextEventMatchingListInModeWithFilter
ReceiveNextEventCommon
RunCurrentEventLoopInMode
CFRunLoopRunSpecific
__CFRunLoopRun
__CFRunLoopDoSource1
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__
mshMIGPerform
_XCopyParameterizedAttributeValue
_AXXMIGCopyParameterizedAttributeValue
CopyParameterizedAttributeValue
NSAccessibilityEntryPointValueForAttributeWithParameter
NSAccessibilityPerformEntryPointObject
___NSAccessibilityEntryPointValueForAttributeWithParameter_block_invoke.821
-[MOXAccessibleBase accessibilityAttributeValue:forParameter:]
-[MOXSearchInfo performSearch]
-[MOXSearchInfo getMatchesForRule:]
mozilla::a11y::Pivot::SearchForward(mozilla::a11y::AccessibleOrProxy&, mozilla::a11y::PivotRule&, bool)
RotorLinkRule::Match(mozilla::a11y::AccessibleOrProxy const&)
-[mozTablePartAccessible moxRole]
-[mozTablePartAccessible isLayoutTablePart]
mozilla::a11y::TableAccessible::IsProbablyLayoutTable()
{virtual override thunk({offset(-136)}, nsContentList::Length())}
nsContentList::PopulateSelf(unsigned int, unsigned int)

Comment 1

[Marco Zehe (:MarcoZ)]

Nominating for 86 work.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1680840: Introduce caching for IsLayoutTable r?eeejay

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1680840: Fire obj attr changed events to invalidate isLayouTable cache. r?eeejay

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1680840: Test table layout caching r?eeejay

Depends on D101512

Comment 5

[Phabricator Automation]

Comment on attachment 9196684 [details]
Bug 1680840: Introduce caching for IsLayoutTable r?eeejay

Revision D101512 was moved to bug 1688730. Setting attachment 9196684 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9198525 [details]
Bug 1680840: Test table layout caching r?eeejay

Revision D102652 was moved to bug 1688730. Setting attachment 9198525 [details] to obsolete.

Comment 7

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1680840: Fire table styling changed event when style changes that may affect data/layout table classification r?emilio

Comment 8

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1680840: Introduce table style changed event to mac platform, update caching r?eeejay

Depends on D103254

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2448b72b79ae
Fire table styling changed event when style changes that may affect data/layout table classification r=emilio,eeejay
https://hg.mozilla.org/integration/autoland/rev/5f846d21fa37
Introduce table style changed event to mac platform, update caching r=eeejay

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2448b72b79ae
https://hg.mozilla.org/mozilla-central/rev/5f846d21fa37