Closed Bug 1681004 Opened 4 years ago Closed 7 months ago

[wpt-sync] Sync PR 26772 - Revert "Add support for ReadableStreamBYOBReader & ByteStreamController"

Categories

(Core :: DOM: Streams, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26772 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26772
Details from upstream follow.

b'Alexey Baskakov <loyso@chromium.org>' wrote:

Revert "Add support for ReadableStreamBYOBReader & ByteStreamController"

This reverts commit c85fa18ea9fd78fb9c992ac3dca9ae41d2f0a2a3.

Reason for revert: Crashes in webkit_unit_tests
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/19136/overview

Original change's description:

Add support for ReadableStreamBYOBReader & ByteStreamController

This CL adds the main implementation for supporting BYOB readers
and byte stream controllers for readable streams according to
the Streams API standard[1]. As added in previous CLs, this is
done using polymorphism where there are two base classes:

  • ReadableStreamGenericReader, and
  • ReadableStreamController
    which the default/BYOB readers and default/byte stream controllers
    inherit from. This approach is further elaborated upon in detail
    in the design document[2].

The three main classes that implementation was added for in
this CL are:

  1. ReadableStreamBYOBReader
  2. ReadableByteStreamController
  3. ReadableStreamBYOBRequest

This CL also includes:

  • new GetBYOBReader unittest
  • UnderlyingSource WebIDL files [3]
    among other things for adding the functionality of supporting
    readable byte streams.

[1] https://streams.spec.whatwg.org/
[2] https://docs.google.com/document/d/1rvKpGjppeqRSWntokY-ft_hU2i2us8gis6zgrrLWSTI/view#
[3] https://streams.spec.whatwg.org/#underlying-source-api

Bug: 614302
Change-Id: I380258453e6fd5d617810e21fa8996f8f08b26f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537281
Commit-Queue: Nidhi Jaju \<nidhijaju@google.com>
Reviewed-by: Yutaka Hirano \<yhirano@chromium.org>
Reviewed-by: Adam Rice \<ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833711}

TBR=ricea@chromium.org,yhirano@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nidhijaju@google.com

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 614302
Change-Id: I166ca8694be54d3d6d9b0e88637e875c379f12fb

Reviewed-on: https://chromium-review.googlesource.com/2574646
WPT-Export-Revision: 0bbe72896c4561731b11eeec6773adf9bb3f9749

Component: web-platform-tests → JavaScript Engine
Product: Testing → Core
Component: JavaScript Engine → DOM: Streams
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.