1681010 - Overlapping text in search box

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Avinash Mishra]

Attachment: thunderbird search.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Open Thunderbird
Open Today's pane

Actual results:

The text in search box beside quick filter is overlapping with magnifying glass.

Expected results:

The text should resize to fit the search box.

Comment 1

[WaltS48 [:walts48]]

I can reproduce using 84.0b3 and 78.5.1 on Ubuntu 18.04 LTS when resizing the window smaller.
The text disappears from the search box when resizing the window using version 68.10.0 from Ubuntu.

Comment 2

[Alice0775 White]

#1 Regression window(Good -> no gloda search bar):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=6f78a5f43bcd37506a93e56090d1de412c4fc6bc&tochange=5f512492b2ebf2c616ae3b1c41b64b9254d83f26
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=04da00a61c6df437250e3af0d20f8ec72bbe9f48&tochange=9596d7f4a7457bccc78cadf9c39bcc9c4b5b97f8

#2 pertially proglesion window(no gloda search bar -> this bug)
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=dd918656e4d7e4c79ebf44d9cb4e31eec406c1de&tochange=a96336115ce738cabc6bc86cb156067dd417e05f
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b3ecb5aef45a8fb74764bb32e54567d57ed00383&tochange=6b93a83735ed3ab3b57b46c1b768814b1a1af5d6

Suspect: 95aa8237c44ec527e591effa0f3857b0c2a0b29e Alessandro Castellani — Bug 1542720 - [de-xbl] convert the glodaSearch binding. r=mkmelin DONTBUILD

Comment 3

[Thomas D. (:thomas8)]

Richard, right now the background of the magnifier icon seems to be transparent, which seems to cause the distorted look. Could this be fixed by assigning the background color variable of the search input to the magnifier icon image?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1681010-gloda-searchbox.patch

I moved the search glass to the left like we have already for the other search boxes which use the toolkit styling. Instead of a background image I'm using now a separate image to be able to turn it on RTL languages. The placeholder text begins now at the correct position and will be cut at the end of the box like it should.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9192057 [details] [diff] [review]
1681010-gloda-searchbox.patch

Review of attachment 9192057 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.
Too bad we don't have the gloda search as a Custom Element like the `search-textbox`, maybe for another bug.

::: mail/themes/linux/mail/searchBox.css
@@ +11,5 @@
>  
> +.search-icon {
> +  list-style-image: url(chrome://global/skin/icons/search-textbox.svg);
> +  margin-inline: 7px -21px;
> +}

Any chance of putting this in a shared file?
How does it look on macos?

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1681010-gloda-searchbox.patch [landed on C-C]

Unified as much as possible.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9192260 [details] [diff] [review]
1681010-gloda-searchbox.patch  [landed on C-C]

Review of attachment 9192260 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/409b280ef386
Use the toolkit search-textbox.svg to unify the search text box styling. r=aleca

Comment 9

[Thomas D. (:thomas8)]

Wow, that was quick after I invited Richard to the party, thanks much to Richard and Alex!

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1681010-mac-fix-search-icon-color.patch

Opposite to the icons on Linux and Windows, the Mac icon has no colour set for the search glass so we need to set it. Best visible with the dark theme.

Comment 11

[Alessandro Castellani [:aleca]]

Comment on attachment 9193257 [details] [diff] [review]
1681010-mac-fix-search-icon-color.patch

Review of attachment 9193257 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I completely missed this.
Thanks!

Comment 12

[Alessandro Castellani [:aleca]]

Should we request an uplift for these?

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 9192260 [details] [diff] [review]
1681010-gloda-searchbox.patch [landed on C-C]

[Approval Request Comment]
User impact if declined: placeholder text overlaps the search glass with narrow search field
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Richard Marti (:Paenglab)]

Comment on attachment 9193257 [details] [diff] [review]
1681010-mac-fix-search-icon-color.patch

[Approval Request Comment]
User impact if declined: placeholder text overlaps the search glass with narrow search field
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ed5bceb4661
Follow-up: Fix the search glass color on macOS. r=aleca

Comment 16

[Richard Marti (:Paenglab)]

Comment on attachment 9192260 [details] [diff] [review]
1681010-gloda-searchbox.patch [landed on C-C]

ESR needs his own patch.

Comment 17

[Richard Marti (:Paenglab)]

Attachment: 1681010-gloda-searchbox-ESR.patch

[Approval Request Comment]
User impact if declined: placeholder text overlaps the search glass with narrow search field
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9192260 [details] [diff] [review]
1681010-gloda-searchbox.patch [landed on C-C]

[Triage Comment]
Approved for beta

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9193257 [details] [diff] [review]
1681010-mac-fix-search-icon-color.patch

[Triage Comment]
Approved for beta

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9193462 [details] [diff] [review]
1681010-gloda-searchbox-ESR.patch

[Triage Comment]

Comment 21

[Rob Lemley [:rjl]]

Please clarify: Only attachment 9193462 [details] [diff] [review] for esr78?

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/eccedb4d29c9

Comment 23

[Richard Marti (:Paenglab)]

(In reply to Rob Lemley [:rjl] from comment #21)

Please clarify: Only attachment 9193462 [details] [diff] [review] for esr78?

Yes.

Comment 24

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/21b84ee1df70

Comment 25

[WaltS48 [:walts48]]

Verifying in the 78.6.1 rc on Windows 10.