Closed Bug 1681058 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26774 - Non-auto thickness makes underline non-simple

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26774 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26774
Details from upstream follow.

b'Dominik R\xc3\xb6ttsches <drott@chromium.org>' wrote:

Non-auto thickness makes underline non-simple

Upgrade underline to non-simple when a thickness is set. Without this
change, only modifying the text-decoration-thickness property was
disregarded when no other properties are set, as the
hasSimpleUnderline() optimization was used in this case in
ComputedStyle.

Add a non-match type WPT test to ensure that a difference is seen when
two different thicknesses are set.

Fixed: 1154537
Change-Id: Id0413fc3f44e154b509e21b5f857f13f8d80a8f4

Reviewed-on: https://chromium-review.googlesource.com/2577457
WPT-Export-Revision: 760250f9477ea4f0b5625aaa2bd221b23ab3754f

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-text-decor/text-decoration-thickness-single.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/71ac5b5b19be [wpt PR 26774] - Non-auto thickness makes underline non-simple, a=testonly https://hg.mozilla.org/integration/autoland/rev/ae3f1a7f3cd1 [wpt PR 26774] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.