Closed
Bug 1681067
Opened 5 years ago
Closed 4 years ago
`return nullptr` is not consistently highlighted.
Categories
(Conduit :: Phabricator, defect, P5)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nbp, Assigned: arai)
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
While reviewing https://phabricator.services.mozilla.com/D97662 I noticed a minor issue where return nullptr is highlighted differently between the removed code and the added code, which might be related to the fact that it was in a class body in the removed code.
Removed: js/src/vm/JSScript.h line 2130
Added: js/src/vm/JSScript.cpp line 738
|
||
Updated•5 years ago
|
Keywords: conduit-upstream
Priority: -- → P3
|
|
||
Updated•5 years ago
|
Keywords: conduit-triaged
|
|
||
Updated•5 years ago
|
Priority: P3 → P5
|
Assignee | |
Comment 1•4 years ago
|
||
This is because h is treated as C code, while cpp is treated as C++ code, and nullptr is keyword only in C++ code.
|
|
Assignee | |
Updated•4 years ago
|
Keywords: conduit-upstream
|
|
Assignee | |
Comment 2•4 years ago
|
||
Assignee: nobody → arai.unmht
|
||
Comment 3•4 years ago
|
||
Merged
https://github.com/mozilla-conduit/phabricator/commit/86a03a2466682a1bb6a4096f751f4903780c4efd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•