Closed Bug 1681083 Opened 4 years ago Closed 4 years ago

Make the newmail alert dark with dark themes

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 fixed)

VERIFIED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

The new mail alert uses only the system colours and not the dark theme colours when the dark theme is enabled.

Using the lightweightthemes="true" in the XHTML doesn't work. When set no alert is shown. Maybe because of CSP restrictions.

But we can use the @media (prefers-color-scheme: dark) media query which is enabled when a dark TB theme is set.

Additionally I also removed the <stack> and the close-button.png for Linux. We use now the toolkit close.svg like on Windows. This change made it possible to use only the shared newmailalert.css.

To look better with HiDPI screens I added the 128px icon.

Attachment #9191654 - Flags: review?(alessandro)
Attachment #9191654 - Attachment is patch: true
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Type: task → defect
Comment on attachment 9191654 [details] [diff] [review] 1681083-nemailalert-dark.patch Review of attachment 9191654 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #9191654 - Flags: review?(alessandro) → review+
Target Milestone: --- → 85 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d34c0c8bc0bc
Make the newmail alert dark with dark themes. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9191654 [details] [diff] [review]
1681083-nemailalert-dark.patch

[Approval Request Comment]
User impact if declined: New message alert not following the dark theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9191654 - Flags: approval-comm-beta?

[Approval Request Comment]
User impact if declined: New message alert not following the dark theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9191930 - Flags: approval-comm-esr78?

Comment on attachment 9191930 [details] [diff] [review]
1681083-nemailalert-dark-ESR.patch

[Triage Comment]
Approved for esr78

Attachment #9191930 - Flags: approval-comm-esr78? → approval-comm-esr78+

Comment on attachment 9191654 [details] [diff] [review]
1681083-nemailalert-dark.patch

[Triage Comment]
(no beta uplift, so this will be in beta 85)

Attachment #9191654 - Flags: approval-comm-beta? → approval-comm-beta-

Building comm-esr78 locally and running "package" I get:
0:08.22 ERROR: The following duplicated files are not allowed:
0:08.22 chrome/classic/skin/classic/messenger/newmailalert.css
0:08.22 chrome/classic/skin/classic/messenger/shared/newmailalert.css

Verified in my testing of the 78.6.0 release candidate on Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: