Make the newmail alert dark with dark themes
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
14.35 KB,
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta-
|
Details | Diff | Splinter Review |
14.31 KB,
patch
|
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
The new mail alert uses only the system colours and not the dark theme colours when the dark theme is enabled.
Assignee | ||
Comment 1•4 years ago
|
||
Using the lightweightthemes="true"
in the XHTML doesn't work. When set no alert is shown. Maybe because of CSP restrictions.
But we can use the @media (prefers-color-scheme: dark)
media query which is enabled when a dark TB theme is set.
Additionally I also removed the <stack> and the close-button.png for Linux. We use now the toolkit close.svg like on Windows. This change made it possible to use only the shared newmailalert.css.
To look better with HiDPI screens I added the 128px icon.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d34c0c8bc0bc
Make the newmail alert dark with dark themes. r=aleca
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9191654 [details] [diff] [review]
1681083-nemailalert-dark.patch
[Approval Request Comment]
User impact if declined: New message alert not following the dark theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Assignee | ||
Comment 5•4 years ago
|
||
[Approval Request Comment]
User impact if declined: New message alert not following the dark theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Comment 6•4 years ago
|
||
Comment on attachment 9191930 [details] [diff] [review]
1681083-nemailalert-dark-ESR.patch
[Triage Comment]
Approved for esr78
Comment 7•4 years ago
|
||
Comment on attachment 9191654 [details] [diff] [review]
1681083-nemailalert-dark.patch
[Triage Comment]
(no beta uplift, so this will be in beta 85)
Comment 8•4 years ago
|
||
bugherder uplift |
Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/df6546983bcf
Comment 9•4 years ago
|
||
Building comm-esr78 locally and running "package" I get:
0:08.22 ERROR: The following duplicated files are not allowed:
0:08.22 chrome/classic/skin/classic/messenger/newmailalert.css
0:08.22 chrome/classic/skin/classic/messenger/shared/newmailalert.css
Comment 10•4 years ago
|
||
Verified in my testing of the 78.6.0 release candidate on Windows 10.
Description
•