1681084 - Remove unused RegExpShared::compile methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[André Bargull [:anba]]

• Remove unused RegExpShared::compile method.
• Avoid unnecessary string atomization in EscapeRegExpPattern.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1681084 - Part 1: Remove unused RegExpShared::compile methods. r=iain!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1681084 - Part 2: Avoid unnecessary string atomization in EscapeRegExpPattern. r=iain!

Depends on D98928

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e787af20b790
Part 1: Remove unused RegExpShared::compile methods. r=iain
https://hg.mozilla.org/integration/autoland/rev/a2194d3d0611
Part 2: Avoid unnecessary string atomization in EscapeRegExpPattern. r=iain

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing SM bustage in RegExpObject.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/3834b853bf867b953c95ce1c0bff64fc174f2602

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=UusFnd8vSM6No7UUfrCq-g.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=a2194d3d06111cd8e1d57c9f20ea0f14759733f1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324026735&repo=autoland&lineNumber=5637

" TinderboxPrint: rooting hazards<br/>1
[task 2020-12-09T11:05:01.813Z] TinderboxPrint: (unsafe references to unrooted GC pointers)<br/>86
[task 2020-12-09T11:05:01.813Z] TinderboxPrint: (unnecessary roots)<br/>1006
[task 2020-12-09T11:05:01.813Z] TinderboxPrint: missing expected hazards<br/>0
[task 2020-12-09T11:05:01.813Z] TinderboxPrint: heap write hazards<br/>0
[task 2020-12-09T11:05:01.815Z] TEST-UNEXPECTED-FAIL | hazards | unrooted 'this' of type 'js::RegExpObject*' live across GC call at js/src/vm/RegExpObject.cpp:483
[task 2020-12-09T11:05:01.815Z] TEST-UNEXPECTED-FAIL | hazards | 1 rooting hazards detected
[task 2020-12-09T11:05:01.815Z] TinderboxPrint: documentation<br/><a href='https://wiki.mozilla.org/Javascript:Hazard_Builds#Diagnosing_a_rooting_hazards_failure'>static rooting hazard analysis failures</a>, visit "Inspect Task" link for hazard details
[task 2020-12-09T11:05:01.815Z] + grab_artifacts
[task 2020-12-09T11:05:01.815Z] + local artifacts
[task 2020-12-09T11:05:01.815Z] + artifacts=/builds/worker/artifacts
[task 2020-12-09T11:05:01.815Z] + '[' -d /builds/worker/workspace/haz-js ']'
[task 2020-12-09T11:05:01.815Z] + cd /builds/worker/workspace/haz-js"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/787dc0f65eef
Part 1: Remove unused RegExpShared::compile methods. r=iain
https://hg.mozilla.org/integration/autoland/rev/9adc3762b1eb
Part 2: Avoid unnecessary string atomization in EscapeRegExpPattern. r=iain

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/787dc0f65eef
https://hg.mozilla.org/mozilla-central/rev/9adc3762b1eb