Closed
Bug 1681136
Opened 5 years ago
Closed 5 years ago
Investigate BranchEmitter branch generation
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: mgaudet, Assigned: arai)
Details
Attachments
(4 files)
In D98756 Iain noted that we generate
Not
IfEq
vs just generating IfNe. This is a property of BranchEmitterBase according to Arai, potentially driven by a JIT weakness once upon a time.
We should see if we can improve the story here and avoid that Not if possible.
|
||
Comment 1•5 years ago
|
||
IonControlFlow (removed in bug 1595476) didn't support IfNe (outside of loops).
|
Reporter | |
Comment 2•5 years ago
|
||
Thanks for the pointer! Definitely can be cleaned up then.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D99084
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D99085
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D99086
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/8cf11c8f92ba
Part 1: Rename BranchEmitterBase::Kind to BranchEmitterBase::LexicalKind. r=yulia
https://hg.mozilla.org/integration/autoland/rev/79f63086887e
Part 2: Support IfNe in IfEmitter/InternalIfEmitter. r=yulia
https://hg.mozilla.org/integration/autoland/rev/e6dafa53dd61
Part 3: Use IfNe in syntactic if-then-else and conditional expression. r=yulia
https://hg.mozilla.org/integration/autoland/rev/c9a48f273f2f
Part 4: Use IfNe in internal if-then. r=yulia
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8cf11c8f92ba
https://hg.mozilla.org/mozilla-central/rev/79f63086887e
https://hg.mozilla.org/mozilla-central/rev/e6dafa53dd61
https://hg.mozilla.org/mozilla-central/rev/c9a48f273f2f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•