Closed Bug 1681328 Opened 1 year ago Closed 1 year ago

add more domains for Amazon and eBay tippytop icons

Categories

(Firefox :: Top Sites, enhancement, P1)

enhancement
Points:
2

Tracking

()

VERIFIED FIXED
85 Branch
Iteration:
85.2 - Nov 30 - Dec 13
Tracking Status
firefox84 + verified
firefox85 + verified
firefox86 --- verified

People

(Reporter: mconnor, Assigned: dao)

Details

Attachments

(1 file)

Severity: -- → S2
Status: NEW → ASSIGNED
Iteration: --- → 85.2 - Nov 30 - Dec 13
Points: --- → 2
Priority: -- → P1
Summary: add more domains to top sites for Amazon and eBay → add more domains for Amazon and eBay tippytop icons
Flags: qe-verify?
Flags: qe-verify? → qe-verify+

[Tracking Requested - why for this release]: We'd like to enable Sponsored Top Sites for more regions as soon as possible and having the Amazon and eBay logo images appear is crucial to that effect.

Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d8525f4a03c
add more domains for Amazon and eBay tippytop icons. r=mikedeboer

Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0 & comment 2
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Add said URLs as top sites in the new tab page and check if they get the high-quality icon
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Fairly straightforward config change
  • String changes made/needed:
Attachment #9192165 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
QA Whiteboard: [qa-triaged]
Attachment #9192165 - Flags: approval-mozilla-release?

Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer

This is too late for 84.0 given that it ships Tuesday. We can leave it on the radar for 84.0.1.

Attachment #9192165 - Flags: approval-mozilla-beta?

Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer

Approved for 84.0rc3 per Selena.

Attachment #9192165 - Flags: approval-mozilla-release? → approval-mozilla-release+

:dao I'm not sure if I missed this, but how can we verify that the icon is the correct one? And what is the setup needed for verifying this?

Flags: needinfo?(dao+bmo)

You can add those sites manually from the top site section's three dot menu.

Flags: needinfo?(dao+bmo)

I have verified that the icons used for the Amazon and eBay manually added tiles are the correct ones - "chrome://activity-stream/content/data/content/tippytop/images/ebay@2x.png" and "chrome://activity-stream/content/data/content/tippytop/images/amazon@2x.png" - using Firefox Release 84 (Build ID: 20201211215739) , Firefox Beta (Build ID: 20201215185920) and Firefox Nightly (Build ID: 20201216214834) on Windows 10, Linux Mint 20 and macOS 10.15.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.