add more domains for Amazon and eBay tippytop icons
Categories
(Firefox :: Top Sites, enhancement, P1)
Tracking
()
People
(Reporter: mconnor, Assigned: dao)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
We know that users prefer full sized icons, so we should add them for the following domains
Amazon:
www.amazon.com.au
www.amazon.in
www.amazon.com.br
www.amazon.it
www.amazon.co.jp
www.amazon.com.mx
www.amazon.nl
www.amazon.sa
www.amazon.sg
www.amazon.es
www.amazon.se
www.amazon.com.tr
www.amazon.ae
eBay:
www.ebay.ca
www.benl.ebay.be
www.befr.ebay.be
www.ebay.chhttps://mx.ebay.com/
www.ebay.es
www.ebay.fr
www.ebay.ie
www.ebay.it
www.ebay.nl
www.ebay.ch
www.ebay.com.au
www.ebay.in
www.ebay.co.jp
mx.ebay.com
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]: We'd like to enable Sponsored Top Sites for more regions as soon as possible and having the Amazon and eBay logo images appear is crucial to that effect.
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0 & comment 2
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Add said URLs as top sites in the new tab page and check if they get the high-quality icon
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fairly straightforward config change
- String changes made/needed:
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer
This is too late for 84.0 given that it ships Tuesday. We can leave it on the radar for 84.0.1.
Comment 7•4 years ago
|
||
Comment on attachment 9192165 [details]
Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer
Approved for 84.0rc3 per Selena.
Comment 8•4 years ago
|
||
uplift |
Comment 9•4 years ago
|
||
:dao I'm not sure if I missed this, but how can we verify that the icon is the correct one? And what is the setup needed for verifying this?
Assignee | ||
Comment 10•4 years ago
|
||
You can add those sites manually from the top site section's three dot menu.
Comment 11•4 years ago
|
||
I have verified that the icons used for the Amazon and eBay manually added tiles are the correct ones - "chrome://activity-stream/content/data/content/tippytop/images/ebay@2x.png" and "chrome://activity-stream/content/data/content/tippytop/images/amazon@2x.png" - using Firefox Release 84 (Build ID: 20201211215739) , Firefox Beta (Build ID: 20201215185920) and Firefox Nightly (Build ID: 20201216214834) on Windows 10, Linux Mint 20 and macOS 10.15.
Description
•