Closed Bug 1681440 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26811 - [MSE][WebCodecs] WSBI::AppendChunks through parser, plus e2e test

Categories

(Core :: Audio/Video: Playback, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26811 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26811
Details from upstream follow.

b'Matt Wolenetz <wolenetz@chromium.org>' wrote:

[MSE][WebCodecs] WSBI::AppendChunks through parser, plus e2e test

This change:

  1. Implements WebSourceBufferImpl::AppendChunks(), plumbing the appended
    chunks through ChunkDemuxer into the stream parser's ProcessChunks().

  2. Implements WebCodecsEncodedChunkStreamParser::ProcessChunks(),
    emitting cached config when necessary (prior to calling the
    NewBuffersCB, initially, or if a flush() operation had just happened
    before the chunks were appended.

  3. Aligns as much as possible with existing architecture for similar
    handling by regular bytestream parsers, for improved reuse and
    maintainability.

  4. Adds a basic end-to-end vp9 video chunk buffering and playback test.

Later refinements will add more tests and may improve usability with
things like EncodedAudioChunk duration, EncodedVideoChunk
decodeTimestamp, and h264 support (where applicable by build flags).

BUG=1144908

Change-Id: Ib787d22b0171826fa28bdbb776410e02e25a9cba
Reviewed-on: https://chromium-review.googlesource.com/2575501
WPT-Export-Revision: e25a5e5714a21cd92905fd846817624e65a8af05

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
FAIL : 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/media-source/mse-for-webcodecs/tentative/mediasource-webcodecs-appendencodedchunks-play.html: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ef6248f8981 [wpt PR 26811] - [MSE][WebCodecs] WSBI::AppendChunks through parser, plus e2e test, a=testonly https://hg.mozilla.org/integration/autoland/rev/20c1c15ea6cd [wpt PR 26811] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.