1681469 - Allow nsBaseHashtable to work with a non-default-constructible/non-movable DataType

Status: RESOLVED FIXED

(Core :: XPCOM, task, P2)

Description

[Jan Varga [:janv]]

We are converting some code to use NotNull in bug 1680275. It works fine with nsTArray, but nsTHashtable and other hash table classes currently don't work with NotNull. The main problem is that NotNull can't be default constructed.

An experimental patch can be found here: https://phabricator.services.mozilla.com/D99198

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1681469 - Allow nsBaseHashtable to work with a non-default-constructible/non-movable DataType; r=sg

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1681469 - Some amendments.

Comment 3

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=687271545a367e26f49b270f6f64fc6bcff971c3

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1681469 - Replace LookupForAdd with WithRawEntry

This is a temporary patch which eventually gets folded into D99428.

Depends on D99428

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ecaa139c502
Allow nsBaseHashtable to work with a non-default-constructible/non-movable DataType; r=nika

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 6ecaa139c502 (bug 1681469) for gtest AddressSanitizer failures.
https://hg.mozilla.org/integration/autoland/rev/9ba39e91c27cd7d34515cadcf3ff42adfdce2bd9

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=6ecaa139c502671fb8b62553cdf16f2a36151b73&selectedTaskRun=eZ67qp8bTU67j6XT-Ctd5w.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=328168919&repo=autoland&lineNumber=2953

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78a57e651002
Allow nsBaseHashtable to work with a non-default-constructible/non-movable DataType; r=nika

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/78a57e651002

Comment 9

[Phabricator Automation]

Comment on attachment 9193208 [details]
Bug 1681469 - Some amendments.

Revision D99764 was moved to bug 1688833. Setting attachment 9193208 [details] to obsolete.

Comment 10

[Jan Varga [:janv]]

Landed again after disabling code which doesn't work in ASAN builds.