Closed Bug 1681545 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26821 - Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26821 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26821
Details from upstream follow.

b'Thiemo Nagel <tnagel@chromium.org>' wrote:

Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"

This reverts commit 258f848692cfb26af87e0828bc02e1f5a9d31c72.

Reason for revert: failure in browser_tests/TabStripTabListTest.All

As unlikely as it looks (to me), I've bisected test failure to this CL

Builder Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29

Original change's description:

IO: Use pre-margin target rect for an empty check for intersection threshold

This patch ensures that we use a pre-margin version of the target rect
if we are checking whether it was empty. This is to make sure that we
compute a "1" intersection ratio in cases where an ancestor of a
margin-padded target causes it to be empty.

In this case, we should report 1 intersection, because we are intersecting
and target is an empty rect. However, because we padded the target
with a margin, we ended up doing the wrong check and ultimately compute
0 intersection in a different conditional branch (before this patch).

This patch restores correct behavior.

R=​szager@chromium.org, chrishtr@chromium.org
Fixed: 1156815

Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046
Reviewed-by: Stefan Zager \<szager@chromium.org>
Commit-Queue: vmpstr \<vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834930}

TBR=szager@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Idf7927cbd535d91db51da4f3f97280c2359e9b97
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582059
Reviewed-by: Thiemo Nagel \<tnagel@chromium.org>
Commit-Queue: Thiemo Nagel \<tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835216}

PR 26821 applied with additional changes from upstream: ffd5f1adee3ec39744638e28321d652f866e3e5c
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b30380c0fb1a [wpt PR 26821] - Revert "IO: Use pre-margin target rect for an empty check for intersection threshold", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.