1681545 - [wpt-sync] Sync PR 26821 - Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26821 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26821
Details from upstream follow.

b'Thiemo Nagel <[e-mail]>' wrote:

Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"

This reverts commit 258f848692cfb26af87e0828bc02e1f5a9d31c72.

Reason for revert: failure in browser_tests/TabStripTabListTest.All

As unlikely as it looks (to me), I've bisected test failure to this CL

Builder Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29

Original change's description:

IO: Use pre-margin target rect for an empty check for intersection threshold

This patch ensures that we use a pre-margin version of the target rect
if we are checking whether it was empty. This is to make sure that we
compute a "1" intersection ratio in cases where an ancestor of a
margin-padded target causes it to be empty.

In this case, we should report 1 intersection, because we are intersecting
and target is an empty rect. However, because we padded the target
with a margin, we ended up doing the wrong check and ultimately compute
0 intersection in a different conditional branch (before this patch).

This patch restores correct behavior.

R=​[e-mail], [e-mail]
Fixed: 1156815

Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046
Reviewed-by: Stefan Zager \<[e-mail]>
Commit-Queue: vmpstr \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#834930}

TBR=[e-mail],[e-mail],[e-mail],[e-mail]

Change-Id: Idf7927cbd535d91db51da4f3f97280c2359e9b97
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582059
Reviewed-by: Thiemo Nagel \<[e-mail]>
Commit-Queue: Thiemo Nagel \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#835216}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 26821 applied with additional changes from upstream: ffd5f1adee3ec39744638e28321d652f866e3e5c

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a6d72996c695776ca9be1186bbfa407e76c8850

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30380c0fb1a
[wpt PR 26821] - Revert "IO: Use pre-margin target rect for an empty check for intersection threshold", a=testonly

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b30380c0fb1a