1681632 - [eliot] [traceback] OSError: [Errno 18] Invalid cross-device link

Status: RESOLVED FIXED

(Eliot :: General, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry issue: https://sentry.prod.mozaws.net/operations/symbols-stage/issues/10231014/

OSError: [Errno 18] Invalid cross-device link: '/tmp/junk/tmpiw107xt8.sym' -> '/tmp/cache/xul.pdb___E13A92B380043FC04C4C44205044422E1.symc'
  File "eliot/cache.py", line 139, in set
    Path(temp_fp.name).rename(filepath)
  File "python3.9/pathlib.py", line 1377, in rename
    self._accessor.rename(self, target)

What's going on is that in stage (and likely this will be true in prod, too), /tmp/junk/ and /tmp/cache/ are different volumes and so we can't just rename across them.

Need to figure out how to do this in the same volume, in a way that doesn't create a race condition when saving the file, and doesn't mess up the max size of the cache.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We should add some documentation for "how big should the cache be?" and maybe use "20x biggest SYM file" as a good rule-of-thumb or something like that.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2321: bug 1681632: rework things so everything is in the cachedir

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2321: "bug 1681632: rework things so everything is in the cachedir" in 9d13b6f.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

The Sentry link doesn't work anymore. I'm pretty sure the data expired.

I see symbolication running in stage and I don't see errors coming out, so I think pr 2321 fixed it. Marking as FIXED.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Moving to Eliot product.