1681659 - Port bug 1674806 - Remove windowtype attribute from mail/components/preferences/dialogs

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task, P5)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1674806 +++

https://searchfox.org/comm-central/search?q=windowtype%3D&path=mail%2Fcomponents%2Fpreferences&case=false&regexp=false

The windowtype attribute is not needed for these and can just be removed.

Comment 1

[gero]

Hi,

of course I gladly remove them as well. Br
gyj

Comment 2

[Magnus Melin [:mkmelin]]

Great, please go ahead and send us a patch. For setting up comm-central, see https://developer.thunderbird.net/

Comment 3

[gero]

Sorry, i'm very newbie - didn't check it's not in firefox. I don't want to check out and setup commcentral only for this fix. Rather I stay at firefox for now.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1681659-remove-windowtype.patch

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9192475 [details] [diff] [review]
1681659-remove-windowtype.patch

Review of attachment 9192475 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9d851f8bb37
Port bug 1674806: Remove windowtype attribute from mail/components/preferences. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

Unfortunately used by tests: https://searchfox.org/comm-central/search?q=Mailnews%3AarchiveOptions&path=&case=true&regexp=false so causing some orange

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/950ad853244b
Backed out changeset b9d851f8bb37 for test failures in comm/mail/test/browser/account/browser_archiveOptions.js

Comment 9

[Richard Marti (:Paenglab)]

Magnus, I don't know how to open the dialog without this windowtype checking. Please, can you help me? Is there another function to open the dialog in tests?

Comment 10

[Magnus Melin [:mkmelin]]

The tests should preferably be rewritten to use BrowserTestUtils.domWindowOpened or something like that.
But, to just get rid of the windowtype attribute, I think we can just replace it with "id" instead and the test should continue to work.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: 1681659-remove-windowtype.patch

Using an ID now. Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=fad4aaa8f2fa91ecfca8e8483369dd56b36468cd

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9192775 [details] [diff] [review]
1681659-remove-windowtype.patch

Review of attachment 9192775 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, r=mkmelin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c989a1970f12
Port bug 1674806: Remove windowtype attribute from mail/components/preferences. r=mkmelin DONTBUILD