1681697 - Private mode offers switch-to-tab option for normal-mode open sites (must be top sites)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Suggested Severity:]

S3

[Description:]

When a site is opened in normal mode and is in topsites, the private window will offer switch-to-tab option when private mode topsites are loaded.

[Environments:]

Windows 10, Mac 10.14.6, Ubuntu 20.04
85.0a1 2020-12-09
84.0 2020-12-07
83.0
78.5.0esr

[Steps:]

1. (optional)New profile.
2. Open a new tab, select and load one of the top sites.
3. Open a private window and click the addressbar.

[Actual Result:]

The top-site opened in normal window is shown with the switch-to-tab option, even thought we're in private mode. Clicking on it does nothing.

[Expected Result:]

There is no switch-to-tab option in private window.

[Note:]

1. The above scenario doesn't reproduce if the site is not in the top-sites.
2. After the bug 1659752 fix, this issue is more visible.

Comment 1

[Harry Twyford]

This result doing nothing definitely should be fixed.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1681697 - Private window offers broken switch-to-tab option for top sites. r=harry

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3924c54d02b
Private window offers broken switch-to-tab option for top sites. r=harry

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e3924c54d02b

Comment 5

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 86 beta 3 under Win 10 64-bit and Ubuntu 18.04 64-bit.