1681698 - Bootstrap thread actor as soon as we start registering breakpoints via the Watcher actor

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Bug 1573327 ensures registering the breakpoints before the process and page starts loading, but this isn't enough to make early breakpoint to work.
For now, the Thread actor is still attached late from the frontend. This prevents setting up the Debugger API early enough and be able to break.

The goal here would be to followup on bug 1573327 and make it so that the Thread actor is "attached", or at least register all what is necessary to make the breakpoint to work.
Ultimately, we would need to get rid of the attach sequence from the frontend and automatically bootstrap the thread actor when the target instantiates, or when we register the breakpoints (this is part of target instantiation).

This is a blocker in order to get breakpoint to work correctly during early fission iframe loads.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1681698 - [devtools] Bootstrap the thread actor early, when the target actor instantiates

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission MVP.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1681698 - [devtools] A few naive cleanups in ThreadActor.

Bin onExceptionUnwind only once, remove unused _scripts attribute, create _debuggerSourcesSeen from constructor.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1681698 - [devtools] Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure.

Comment 5

[Alexandre Poirot [:ochameau]]

Moving the patches that can be landed immediately to bug 1686480.
The one patch left, would have to wait for bug 1683139 to be fixed before landing. That's because we would miss early "paused" packets.
Whereas, if pauses are resources, they will no longer be missed. The resource watcher will receive them, even if emitted early during process startup. And the panel, even if not opened yet, will receive them from the ResourceWatcher cache.

Comment 6

[Phabricator Automation]

Comment on attachment 9196605 [details]
Bug 1681698 - [devtools] Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure.

Revision D101471 was moved to bug 1686480. Setting attachment 9196605 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9196604 [details]
Bug 1681698 - [devtools] A few naive cleanups in ThreadActor.

Revision D101470 was moved to bug 1686480. Setting attachment 9196604 [details] to obsolete.

Comment 8

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 9

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de60c54fee362d39df963d40ab20c413c93bbbb0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf75ed5213a0
[devtools] Bootstrap the thread actor early, when the target actor instantiates r=jdescottes,nchevobbe,devtools-backward-compat-reviewers

Comment 11

[Atila Butkovits]

Backed out for causing failure on browser_browser_resources_console_messages.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9a783fe8ba4064bdc08905dfe0b00d5efdb2bf51

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=N01KcGbnQkuXodUDwuibCg.0&revision=cf75ed5213a0b9575cbac0a40a829607eba97e4a&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-fis-e10s%2Cdt3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329634279&repo=autoland&lineNumber=14398

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fc4465fe35d
[devtools] Bootstrap the thread actor early, when the target actor instantiates r=jdescottes,nchevobbe,devtools-backward-compat-reviewers

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0fc4465fe35d