1681742 - Proposal: Custom Ping Unit Tests

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Chris H-C :chutten]

Testing Pings in Glean SDK products is hard. Let's see if we can come up with a way to make that friendlier.

Comment 1

[Chris H-C :chutten]

Attachment: Proposal Doc

Comment 2

[Chris H-C :chutten]

Specifically requesting feedback from:

• Alessio - Because we've chatted about this
• Jan-Erik - For SDK POV
• Raphael - For testing and QA's POV
• Bea - How's this look for Glean.js?
• Mike - Overall Glean product fit

Comment 3

[Beatriz Rizental [:brizental]]

From a Glean.js standpoint I see no blockers to implement this API and I think the proposed specification is sensitive and has a nice developer experience. :thumbsup from me.

Comment 4

[Jan-Erik Rediger [:janerik]]

Left some questions. I agree we need to improve this, the proposed solution though might not work easily.

Comment 5

[Raphael Aurich [:raphael] UTC+02:00]

Could you give me permissions to comment, please?

Comment 6

[Alessio Placitelli [:Dexter]]

I like the approach and the general concept. I agree with Jan-Erik that there are some technical quirks to work out, first.

Comment 7

[Chris H-C :chutten]

(In reply to Raphael Pierzina [:raphael] UTC+02:00 from comment #5)

Could you give me permissions to comment, please?

Jeepers, I thought it gave everyone at moz commenting. Sorry about that. Should be fixed now.

Comment 8

[Raphael Aurich [:raphael] UTC+02:00]

Great job on this proposal, chutten. This is exciting! I added my comments to the attached Google Doc.

Comment 9

[Chris H-C :chutten]

Feedback's been incorporated. I'm happy to mark this as accepted and move towards filing implementation bugs in the SDK and FOG.