Closed Bug 1681847 Opened 4 years ago Closed 4 years ago

Page content contains a one-pixel line from browser chrome

Categories

(Firefox :: Theme, defect)

Firefox 83
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: asoroudi, Unassigned)

References

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Nothing, it's present everywhere

Actual results:

On any and every page in Firefox, there is a one-pixel horizontal line of browser chrome visible in the content of the page.

Expected results:

The page content should not include any chrome.

You can see it clearly by setting the theme to the included Firefox AlpenGlow. You'll notice a line of blue and pink under the toolbar, in the area of the page content. If you hide the toolbar (with CSS or opening a chromeless popup window), the line is still visible because it's actually in the page content itself.

I dealt with it by overriding the CSS that adds that border in userChrome.css as so:

/Hide one-pixel border in page content/
toolbox#navigator-toolbox {border-bottom:none!important;}

But it shouldn't be necessary. I don't know why there is a one-pixel line in the first place, especially since it is still present even if the browser chrome is removed (eg about:blank in a chromeless window).

Hi Synetech!
I was unable to reproduce this problem.
Please could you add a test case or more exact steps or include any example? That might help us reproduce it.
Also, I will set a component to have a starting point for this. If this is not the right component please feel free to route this ticket to the corresponding team, thanks!

Component: Untriaged → Graphics
Flags: needinfo?(asoroudi)
Product: Firefox → Core

Just set the theme to the Alpenglow theme that comes with Firefox, then notice there is a one-pixel line of blue and pink below the toolbar, in the area where the page content is visible. You can see it in the attached screenshot above.

Flags: needinfo?(asoroudi)

Hi Synetech, sorry about but I was not able to see this problem in the file attached.
Please could you add it again highlighted the area where the problem appears?
Thanks!

Flags: needinfo?(asoroudi)

Synetech, I am pretty sure that is just the border of the toolbar. I'm not sure why you say it is included in the content of the page?

Moving to Firefox/theme as it's more a theming issue than a graphics one. But I think this is the expected behaviour.

Component: Graphics → Theme
Product: Core → Firefox

It's in the page content because it's still visible even when the toolbar isn't shown. I originally thought it was an issue with popup windows when I posted bug 1530045, but have since realized it's visible everywhere in Firefox, in all pages.

I've attached a screenshot of a chromeless popup window of about:blank (i.e., there is no toolbar or address bar or tabbar or anything), and yet, the one-pixel line is still there even though there shouldn't be anything other than the page content and the OS window chrome. I've attached another screenshot of about:blank with any chrome whatsoever, no browser chrome or even OS window chrome, so it should be nothing but a white window, but the Alpenglow line is still there.

Flags: needinfo?(asoroudi)

Thank you for those screenshots, I see what you mean now.

We don't support chromeless popup windows. How did you make them chromeless?

Flags: needinfo?(asoroudi)

Yeah, I know, you don't support the future of web-apps. 🙄 🤦 It doesn't matter how I removed the toolbar (or the Windows chrome), the fact is, a line of the toolbar is still present in the page content even when it's supposed to be removed because of the CSS line "toolbox#navigator-toolbox".

Flags: needinfo?(asoroudi)

So basically you have a custom method to remove toolbars, won't tell us what exactly you're doing, and are complaining that your method doesn't automatically hide the toolbar's border too. I don't understand what you expect us to do about this.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX

It's not about toolbar being removed, it's about there being an extraneous one-pixel line.

Also, it's not a custom method, I just overrode the code to force the toolbar so that it behaves like before. All you need to do is to remove the CSS line that adds an extraneous one-pixel border between the toolbox and the page content even when the toolbox isn't shown, and/or fix the code that doesn't recognize that border as part of the toolbox and thinks it's part of the page content instead.

Personally, I don't care what you do because I've already removed it by overriding that line in userChrome.css; I was just trying to help fix this bug for other people (at least it's not included in screenshots).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: