1681890 - Remove defer usage in devtools/client/shared/components/test/chrome/head.js

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should use new Promise instead.

Honza

Comment 1

[Abhishek Sharma[:mick]]

hi
I want to work on this bug.

Abhishek

Comment 2

[Tim Nguyen :ntim]

Hi Abishek,

If you're interested in working in this bug, feel free to submit a patch and the bug will be assigned automatically.

Simply remove this line: https://searchfox.org/mozilla-central/rev/0eebf69d04cc0cdd252b135dda2fa9b7c2fa2bfb/devtools/client/shared/components/test/chrome/head.js#17

See https://firefox-source-docs.mozilla.org/setup/contributing_code.html for steps to submit a patch.

Let me know if you've got any questions.

Comment 3

[Dhanesh]

hi, can i work on this?

Comment 4

[Dhanesh]

sir,how to download the source code of ' https://searchfox.org/mozilla-central/rev/0eebf69d04cc0cdd252b135dda2fa9b7c2fa2bfb/devtools/client/shared/components/test/chrome/head.js#17' since there is no github link provided. Bcoz once we found github page of this,we can clone to our local machine and then change the code and make a pull request .Please help

Comment 5

[Abhishek Sharma[:mick]]

hi
I can do it . Thanks for guidance.

Abhishek

Comment 6

[Abhishek Sharma[:mick]]

Hi Tim,
I remove the line but problem arises when I submit the patch. I use git commands and i also installed a tool called moz-phab. But when i run it on git bash its shows command not found. I installed moz-phab in c:\mozilla-build\start-shell.bat. What should i do ?
Can u guide me?

Comment 7

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #6)

Hi Tim,
I remove the line but problem arises when I submit the patch. I use git commands and i also installed a tool called moz-phab. But when i run it on git bash its shows command not found. I installed moz-phab in c:\mozilla-build\start-shell.bat. What should i do ?
Can u guide me?

I personally use Mercurial (hg), the standard Firefox workflow. I'm not too familiar with things on Windows generally.

Usually my workflow is:

1. Run hg up central --clean if not already done
2. Make the changes
3. Run hg commit -m "Bug 1681890 - Remove defer import in devtools/client/shared/components/test/chrome/head.js"
4. Run moz-phab

You might want to chat with folks on the #introduction channel on https://chat.mozilla.org for more specific help :)

Comment 8

[Abhishek Sharma[:mick]]

ok thanks for help.

Comment 9

[Abhishek Sharma[:mick]]

Hi Tim ,
I solve the bug and commit it and all commands are working properly in Mercurial( hg ) but in last when I run moz-phab it shows missing .arrconfig file. Can u guide me ?
What should i do ?

Comment 10

[Abhishek Sharma[:mick]]

where i can add .arrconfig file ?

Comment 11

[Tim Nguyen :ntim]

I'm not sure, I think the "Conduit" channel on https://chat.mozilla.org is more familiar with this (but I'm sure "Introduction" can help as well).

Comment 12

[Abhishek Sharma[:mick]]

Thanks Tim . I asked in Conduit Channel

Comment 13

[Abhishek Sharma[:mick]]

Hi Tim,
Now it works .I have one question, who is the reviewer of this bug. So I add in my commit.

Comment 14

[Abhishek Sharma[:mick]]

I submit my patch and remove the line from the defer . Can you see it?

Comment 15

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #14)

I submit my patch and remove the line from the defer . Can you see it?

I can't, your Phabricator activity looks empty: https://phabricator.services.mozilla.com/p/mick.sharma02/

and there's no listing on Bugzilla either.

Comment 16

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #13)

Hi Tim,
Now it works .I have one question, who is the reviewer of this bug. So I add in my commit.

I'm happy to review this one, since it's pretty straightforward.

Comment 17

[Abhishek Sharma[:mick]]

Hi Tim,
Sorry for late reply. For two days , my health condition is not so good. I check it once again than commit it. Hope you understand.

Comment 18

[Dhanesh]

hi Tim,may i work on this?
i have done the stuff ,only commiting the patch left. @Abishek do u have any objection regarding this? since you the one first asked Tim to work on this bug.If you have any discomfort regarding this..please feel free to tell me I left over to you completely.If not,so that i can submit the patch naa.

Thank you
with a humble,
Dhanesh

Comment 19

[Tim Nguyen :ntim]

If any of you submit a patch, the bug will automatically be assigned to you. There are always other good-first-bugs if the other person doesn't get to it.

Comment 20

[Abhishek Sharma[:mick]]

Hi Tim,
I have a question , when I write your name as a reviewer it says Tim not a valid reviewer name. What name should I write ? or may I write ntim.
Can you please guide ?

Comment 21

[Abhishek Sharma[:mick]]

Attachment: "Bug 1681890 - [devtools] Remove defer import in devtools/client/shared/components/test/chrome/head.js r=ntim"

Comment 22

[Abhishek Sharma[:mick]]

Hi Tim,
I submit my patch . Can you please review it.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea7929f39db5
[devtools] Remove defer import in devtools/client/shared/components/test/chrome/head.js r=ntim

Comment 24

[Abhishek Sharma[:mick]]

Hi Tim,
I want to solve more bugs , where should I find?
Can you help me?

Comment 25

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ea7929f39db5

Comment 26

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #24)

Hi Tim,
I want to solve more bugs , where should I find?
Can you help me?

Bug 1685638 might be interesting.