Closed Bug 1681907 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26851 - Fix a CORS test error

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 26851 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26851
Details from upstream follow.

b'Yutaka Hirano <yhirano@chromium.org>' wrote:

Fix a CORS test error

The following statement throws when "origin" is specified neither
via URL query nor request headers.

request.GET.first(b"origin", request.headers.get(b'origin'))

Fix that by using "none" as the default value.

Clean up cors/basic.htm.

Fixes #26849.

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Whiteboard: [wptsync downstream][domsecurity-backlog] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 5 subtests

Status Summary

Firefox

OK : 13
PASS: 242
FAIL: 4

Chrome

OK : 13
PASS: 246

Safari

OK : 13
PASS: 240
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cors/basic.htm
Cross domain basic usage, origin: echo: FAIL (Chrome: PASS, Safari: FAIL)
Cross domain different port, origin: echo: FAIL (Chrome: PASS, Safari: FAIL)
Cross domain different protocol, origin: echo: FAIL (Chrome: PASS, Safari: FAIL)
/cors/client-hint-request-headers-2.tentative.htm
Client hint headers are simple headers: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/904e5ff89d92 [wpt PR 26851] - Fix a CORS test error, a=testonly https://hg.mozilla.org/integration/autoland/rev/c4972cbefbc9 [wpt PR 26851] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.