1681936 - Perma tier 2 UntrustedModulesFixture.Serialize | Value of: aData.mXULLoadDurationMS.isNothing()

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=324248966&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Gzp15LIUT56laibpWIxsQQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-12-11T12:41:21.421Z] 12:41:21     INFO -  TEST-START | UntrustedModulesFixture.Serialize
[task 2020-12-11T12:41:23.899Z] 12:41:23     INFO -  Received data. (pendingQueries=20)
[task 2020-12-11T12:41:23.948Z] 12:41:23     INFO -  Received data. (pendingQueries=20)
[task 2020-12-11T12:41:23.948Z] 12:41:23  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Value of: aData.mXULLoadDurationMS.isNothing()
[task 2020-12-11T12:41:23.948Z] 12:41:23     INFO -    Actual: false
[task 2020-12-11T12:41:23.948Z] 12:41:23     INFO -  Expected: true @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:158
[task 2020-12-11T12:41:23.998Z] 12:41:23     INFO -  Received data. (pendingQueries=8)
[task 2020-12-11T12:41:24.028Z] 12:41:24     INFO -  Received data. (pendingQueries=6)
[task 2020-12-11T12:41:24.059Z] 12:41:24     INFO -  Received data. (pendingQueries=10)
[task 2020-12-11T12:41:24.059Z] 12:41:24  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | test completed (time: 2638ms)
[task 2020-12-11T12:41:24.059Z] 12:41:24     INFO -  TEST-START | UntrustedModulesFixture.Backup
[task 2020-12-11T12:41:24.089Z] 12:41:24     INFO -  Received data. (pendingQueries=10)
[task 2020-12-11T12:41:24.128Z] 12:41:24     INFO -  Received data. (pendingQueries=9)
[task 2020-12-11T12:41:24.150Z] 12:41:24     INFO -  Received data. (pendingQueries=10)
[task 2020-12-11T12:41:24.181Z] 12:41:24     INFO -  Received data. (pendingQueries=9)
[task 2020-12-11T12:41:24.211Z] 12:41:24     INFO -  Received data. (pendingQueries=10)```

Comment 1

[Razvan Maries]

Toshihito, could you take a look?

Comment 2

[Toshihito Kikuchi [:toshi]]

Interesting. xul.dll in Windows 10 x64 CCov WebRender opt may be signed.

Anyway, this is just a test bug. We can ignore this until fixed. Sorry!

Comment 3

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1681936 - Skip mXULLoadDurationMS check in GTest. r=mhowell

In GTest, xul.dll is considered untrusted because only the FirefoxDirectory
flag of ModuleTrustFlags is turned on. In CCov build, however, xul.dll is
considered trusted because the FirefoxDirectoryAndVersion flag is also turned
on. In the former case, the FirefoxDirectoryAndVersion is not turned on
because when xul.dll is re-built for GTest, its version becomes newer than
firefox.exe. In the CCov build, the version of firefox.exe was also reset
probaly during instrumentation. As a result, the loding event contains a value
in mXULLoadDurationMS in CCov build, but normally not.

This fix removes the check for mXULLoadDurationMS in GTest.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e49837de5f12
Skip mXULLoadDurationMS check in GTest.  r=mhowell

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e49837de5f12

Comment 6

[Intermittent Failures Robot]

5 failures in 4060 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 5

Platform breakdown:

• windows10-64-ccov-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1681936&startday=2020-12-07&endday=2020-12-13&tree=all