1682022 - Use sentence casing for most of the App Menu

Status: RESOLVED FIXED

(Firefox :: Menus, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

This bug doesn't cover the Accounts, Library, Web Developer or Help submenus. Those will be covered in separate bugs, as those strings are likely re-used for things like the menubar.

Comment 1

[Asif Youssuff]

Gnome says "header capitalization" (similar to title casing): https://developer.gnome.org/hig/stable/writing-style.html.en and headerbars (hamburger/app menus) are commonly used there.

macOS doesn't commonly use these menus, but menu bars are generally supposed to use title casing: https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Convert some bookmarking strings to Fluent. r?mak!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Fork some strings from the menubar set in preparation to move them to sentence case. r?mak!

Depends on D100041

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Use sentence casing for the AppMenu. r?mtigley!,flod!

This doesn't include the Accounts, Library, Web Developer or Help submenus.
Those will be addressed in follow-ups.

Depends on D100042

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Fluent migrations for bookmarks and menubar string changes. r?flod!

Depends on D100042

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249ed05c98d7
Convert some bookmarking strings to Fluent. r=mak,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/dc9f6be05525
Fork some strings from the menubar set in preparation to move them to sentence case. r=mak,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e9065a5ef9a6
Fluent migrations for bookmarks and menubar string changes. r=flod

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/249ed05c98d7
https://hg.mozilla.org/mozilla-central/rev/dc9f6be05525
https://hg.mozilla.org/mozilla-central/rev/e9065a5ef9a6

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Fork strings from the context menu and browser.dtd for use in the AppMenu. r?flod!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3aed1881d35
Fork strings from the context menu and browser.dtd for use in the AppMenu. r=flod,fluent-reviewers

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c3aed1881d35

Comment 11

[Mike Conley (:mconley) (:⚙️)]

We're going to need to fork &tabCmd.label; for the AppMenu, too.

Comment 12

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 13

[Romain Testard [:RT]]

Marking as P2. Per experience review we agreed to mark as P1 bugs only bugs that will block MR1.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Going to see if I can rebase this and get this pushed through now that more strings have been forked and the Sync brand strings have been folded up.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Convert to Fluent and / or fork the remainder of the AppMenu strings for sentence casing. r?flod!

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Clone the Extensions for Developers string for sentence-casing when in the AppMenu / panels. r?mtigley!

Depends on D117067

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fca4f56df6f
Convert to Fluent and / or fork the remainder of the AppMenu strings for sentence casing. r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/3a93fa0ba8ce
Clone the Extensions for Developers string for sentence-casing when in the AppMenu / panels. r=mtigley,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/9ec189804055
Use sentence casing for the AppMenu. r=fluent-reviewers,flod,mtigley

Comment 18

[Atila Butkovits]

Backed out for causing failures on browser_sync.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0c3a0379cde46b40310a0e0f33c3b714ad65723

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=HVnhwzWdTq2OljhGXTPJKQ.0&revision=9ec189804055442e5cc98d69dd01b71e90ed0cb5&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cmochitests%2Ctest-macosx1015-64-qr%2Fopt-mochitest-browser-chrome-e10s%2Cbc4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=342285131&repo=autoland&lineNumber=2488

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1682022 - Sentence case some FxA panel strings. r?flod!

Depends on D100043

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4255eacb1dd
Convert to Fluent and / or fork the remainder of the AppMenu strings for sentence casing. r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/87d6e5fca501
Clone the Extensions for Developers string for sentence-casing when in the AppMenu / panels. r=mtigley,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/279ea999e6e6
Use sentence casing for the AppMenu. r=fluent-reviewers,flod,mtigley
https://hg.mozilla.org/integration/autoland/rev/c3a15e3a3a53
Sentence case some FxA panel strings. r=flod,fluent-reviewers

Comment 21

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c4255eacb1dd
https://hg.mozilla.org/mozilla-central/rev/87d6e5fca501
https://hg.mozilla.org/mozilla-central/rev/279ea999e6e6
https://hg.mozilla.org/mozilla-central/rev/c3a15e3a3a53