1682309 - TransportErrorUrlListener is not an nsIUrlListener

Status: RESOLVED FIXED

(Thunderbird :: Security, defect)

Description

[[e-mail]]

nsIUrlListener has two methods, OnStartRunningUrl and OnStopRunningUrl. TransportErrorUrlListener should have implementations for both of them.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9193041 [details] [diff] [review]
Proposed patch

The linter will complain that those curly braces aren't on the same line.

Comment 3

[[e-mail]]

Attachment: Linted patch

When I ran the linter it complained about specialTabs.js and then errored out, so I hadn't realised that it had skipped mailWindowOverlay.js completely. I'll try to remember to lint only the files I change to avoid that in future.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/899f1a395bb7
TransportErrorUrlListener should be an nsIUrlListener r=darktrojan

Comment 5

[Ben Bucksch (:BenB)]

Comment on attachment 9193498 [details] [diff] [review]
Linted patch

[Approval Request Comment]
Regression caused by (bug #): TransportErrorUrlListener
User impact if declined: End users see errors like JavaScript component does not have a method named: "OnStartRunningUrl" in certain situations (cert errors?)
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Fixes broken code. Only adds a missing function. Very low risk.

Comment 6

[Wayne Mery (:wsmwk)]

I'm OK with taking this, but you don't also want this on beta?

Comment 7

[Ben Bucksch (:BenB)]

Yes, good idea.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9193498 [details] [diff] [review]
Linted patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 85.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/71074e9ae46f

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9193498 [details] [diff] [review]
Linted patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/2a56072fbcb6