1682355 - Switch performance test recordFrames from drawWindow to drawSnapshot

Status: NEW

(Firefox :: General, task)

Description

[Steven MacLeod [:smacleod]]

CanvasRenderingContext2D.drawWindow() is synchronous and won't work with fission, so head.js[1] should be updated to use the asynchronous drawSnapshot[2]

1. https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/base/content/test/performance/head.js#418
2. https://searchfox.org/mozilla-central/rev/9b282b34b5/dom/chrome-webidl/WindowGlobalActors.webidl#81-98

Comment 1

[Mike Conley (:mconley) (:⚙️)]

For what it's worth, the tests in browser/base/content/test/performance all are designed to exercise and measure the performance of the browser UI, and not any of the content area. Cross-origin page loads are not a thing we should run into with any of those tests.

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

For what it's worth, the tests in browser/base/content/test/performance all are designed to exercise and measure the performance of the browser UI, and not any of the content area. Cross-origin page loads are not a thing we should run into with any of those tests.

In that case this is most likely fine in the short term and should block Bug 1680359 instead. Thanks!

Comment 3

[Chris Peterson [:cpeterson]]

Do these performance tests use OOP frames? If not, then switching from drawWindow() to drawSnapshot() doesn't need to block shipping Fission MVP. We don't necessarily need to replace all uses of drawWindow() or remove the drawWindow() function itself for Fission MVP.

Comment 4

[Tomislav Jovanovic :zombie]

I filed bug 1682545 specifically for removing the method, as that seems like a better thing to block if we still need sync properties of drawWindow() for perf tests.