1682483 - Fission Crash in [@ mozilla::wr::RenderCompositorD3D11SWGL::AttachExternalImage]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

3/3 crashes with Fission enabled. All crashes on video sites (e.g. twitch.tv)

All crashes on Windows 10 x64, oldest reported build ID is 20201124092228.

Crash report: https://crash-stats.mozilla.org/report/index/21bf07ee-1439-46a2-8e7b-14eb70201215

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(image)

Top 10 frames of crashing thread:

0 xul.dll mozilla::wr::RenderCompositorD3D11SWGL::AttachExternalImage gfx/webrender_bindings/RenderCompositorD3D11SWGL.cpp:336
1 xul.dll webrender_bindings::swgl_bindings::{{impl}}::attach_external_image gfx/webrender_bindings/src/swgl_bindings.rs:1401
2 xul.dll webrender::renderer::Renderer::update_native_surfaces gfx/wr/webrender/src/renderer.rs:5880
3 xul.dll webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:3449
4 xul.dll webrender::renderer::Renderer::update gfx/wr/webrender/src/renderer.rs:2804
5 xul.dll mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:496
6 xul.dll mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:327
7 xul.dll mozilla::detail::RunnableMethodImpl<RefPtr<mozilla::layers::APZCTreeManager>, void  xpcom/threads/nsThreadUtils.h:1201
8 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:548
9 xul.dll base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35

Comment 1

[Jamie Nicol [:jnicol]]

Low numbers but that could be due to low intersection of fission and software-webrender users.

Comment 2

[Matt Woodrow (:mattwoodrow)]

It looks like the other callsites of GetRenderTexture are fallible (at least in release builds), so we should probably do the same here.

Super low numbers and no STR, so no real way to make progress on why this happens (I guess we released our video frame before we'd actually composited it).

Sotaro, do you have an idea on how we should keep these alive until the render thread has finished using them?

Comment 3

[Sotaro Ikeda [:sotaro]]

Assert failure was always the following. Previous line of "MOZ_RELEASE_ASSERT(image);" seemed not hit. RenderTextureHost of the ExternalImageId seemed to exist. But it seemed not a valid type.

MOZ_RELEASE_ASSERT(image->AsRenderDXGITextureHost() || image->AsRenderDXGIYCbCrTextureHost())

• https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/gfx/webrender_bindings/RenderCompositorD3D11SWGL.cpp#507

Comment 4

[Sotaro Ikeda [:sotaro]]

If comment 3 is correct, one possibility is that the following check for update usage is not correct.

• https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/gfx/layers/wr/AsyncImagePipelineManager.cpp#249

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Intermittently disabled D3D11YCbCrImage allocation

With the patch, youtube video playback caused same crash.

Comment 6

[Sotaro Ikeda [:sotaro]]

By Attachment 9197676 [details] [diff], comment 4 seems like one possible cause of the crash.

Comment 7

[Sotaro Ikeda [:sotaro]]

deleted

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)

Assert failure was always the following. Previous line of "MOZ_RELEASE_ASSERT(image);" seemed not hit. RenderTextureHost of the ExternalImageId seemed to exist. But it seemed not a valid type.

MOZ_RELEASE_ASSERT(image->AsRenderDXGITextureHost() || image->AsRenderDXGIYCbCrTextureHost())

• https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/gfx/webrender_bindings/RenderCompositorD3D11SWGL.cpp#507

Since Bug 1687427 fix, I noticed that the "MOZ_RELEASE_ASSERT(image);" exists. There another cause of the problem.

Comment 9

[Sotaro Ikeda [:sotaro]]

Since bug 1687427 fix, amount of crashes seemed to be reduced. It seems OK to make RenderCompositorD3D11SWGL::AttachExternalImage() to fallible like RenderThread::GetRenderTexture().

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1682483 - Make RenderCompositorD3D11SWGL::AttachExternalImage() fallible

Comment 11

[Sotaro Ikeda [:sotaro]]

Sometimes, the following error log exists in crash reports, it might be a hint to the crash.

Updating unknown shared surface: 210453397521

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbd74a090439
Make RenderCompositorD3D11SWGL::AttachExternalImage() fallible r=mattwoodrow

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bbd74a090439