Closed Bug 1682514 Opened 5 months ago Closed 1 month ago

Register the WER runtime exception module at runtime

Categories

(Toolkit :: Crash Reporting, task)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

For a WER runtime exception module to work we also need to register it at runtime in Gecko using the WerRegisterRuntimeExceptionModule() function. Note that the function does not check if the passed path exists and does not return an error if the module wasn't found. We need to make sure that it's where it's supposed to be and properly stored in the registry.

It's possible to pass a raw pointer to a context that will be passed to the callbacks though it's unclear what data can be passed with it.

Summary: Record the WER runtime exception module at runtime → Register the WER runtime exception module at runtime

Note that we'll have to figure out what's the best way to handle browser / child process crashes. We'll probably need to call WerRegisterRuntimeExceptionModule() with a different context in child processes so that the hooks can tell the different crashes apart. I don't think that we'll need separate modules for the different processes though. Note that WerRegisterAdditionalProcess() cannot be used for this purpose, its role seems to be akin to our paired minidump generation: it can be used to add an additional minidump when the registering process crashes.

Blocks: 1682516
Blocks: 1682518
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7de5372675b
Register the Windows Error Reporting exception module so that it can intercept main process crashes r=dmajor
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.