1682599 - [Bug] Selection Action Menu doesn't work on some videos

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

From github: https://github.com/mozilla-mobile/fenix/issues/16077.

Steps to reproduce

• Open a video on ted.com
• Long press on the video to trigger the Selection Action Menu (also didn't know this existed :) )

Expected behavior

• User would expect that tapping on SAVE FILE TO DEVICE would save the video.
• User would expect that tapping on OPEN LINK IN EXTERNAL APP would do something.

Actual behavior

• Download fails
• Open link in external app does nothing

Device information

• Android device: Pixel 4
• Fenix version: Nightly 201020 and Beta 82.0.0-beta 6

Change performed by the Move to Bugzilla add-on.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

This is likely because we don't check that the blob URL is a "valid" one like Firefox Desktop does here: https://searchfox.org/mozilla-central/source/browser/actors/ContextMenuChild.jsm#452

All we have to do is check for URL.isValidURL here: https://searchfox.org/mozilla-central/rev/8883276967d39918e2ce64e873afdd432fb406ca/mobile/android/actors/ContentDelegateChild.jsm#72-75

Comment 2

[[:owlish] 🦉 PST]

This https://searchfox.org/mozilla-central/source/browser/actors/ContextMenuChild.jsm#450-456 seems to come down to BlobURLProtocolHandler::HasDataEntry(url)

Comment 4

[Olivia Hall [:olivia]]

Attachment: Bug 1682599 - Check if media URL is valid before returning it to onContextMenu.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc36386fed69
Check if media URL is valid before returning it to onContextMenu. r=geckoview-reviewers,agi

Comment 6

[Iulian Moraru]

Backed out for causing gv-junit failures on requestContextMenuOnVideo.

Push with failures

Failure log for gv-junit
Failure log for gv-junit-e10s-single

Backout link

The fails appeared only on Android 7.0 x86-64 WebRender debug-isolated-process.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/495da031932f
Check if media URL is valid before returning it to onContextMenu. r=geckoview-reviewers,agi

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/495da031932f

Comment 9

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.