1682676 - Move chrome/content separating line below top InfoBar

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Ed Lee :Mardak]

As part of bug 1673488, we can reduce some confusion about infobars looking like part of the content page by pushing the separating line below and pulling in the edges so the background matches the rest of the chrome/toolbar area.

The changes for this bug can land ahead of proton related themeing changes which might involve changes, e.g., color, sizing, positioning; which would want to be released at the same time as other related proton changes.

See attachment 9191388 [details] as an example (but ignore the background changes to the toolbar/infobar).

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1682676 - Move chrome/content separating line below top InfoBar r?dao!

Adjust styles so the line is drawn at the top of the <browser> instead of below toolbox.

Comment 2

[Ed Lee :Mardak]

Adding some QA notes:

• the main change is to remove the line separating the top chrome area from the infobar which has its edges pulled in to show chrome background
• this change should work for various themes including the packaged ones (light, dark, alpenglow) and more complex ones that show an extended background
• the separating line is maintained for sidebars including bookmark sidebar, devtools

Comment 3

[Ed Lee :Mardak]

It seems like we don't want to separately move the line from the rest of the proton infobar redesign, so marking this incomplete for now.

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1682676 - Position infobars inside of the chrome.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1682676 - Part 1: Move named-deck to toolkit widgets

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1682676 - Part 3: Test infobars inside of the chrome r?ewright

Comment 7

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68e4d95cd11b
Part 1: Move named-deck to toolkit widgets r=jaws
https://hg.mozilla.org/integration/autoland/rev/5134166e9e47
Position infobars inside of the chrome. r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/82b13b029bc5
Part 3: Test infobars inside of the chrome r=ewright

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/68e4d95cd11b
https://hg.mozilla.org/mozilla-central/rev/5134166e9e47
https://hg.mozilla.org/mozilla-central/rev/82b13b029bc5

Comment 10

[Peter Magyari (Desktop QA)]

Verified that the line separating the top chrome area from the infobar was removed, on various themes including the packaged ones.

I've verified this on MacOS 11, Ubuntu 20.04 and Windows 10 using the latest Nightly 88.0a1