1682692 - subtree order in slack's keyboard shortcuts pane is wrong

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Open a slack instance in Firefox
2. Press ctrl+/ to open keyboard shortcuts pane.
3. Go to list item containing string "Move focus through messages"

Result:
List item is named "Move focus through messages up arrow key down arrow key or"

Expected:
List item should be named "Move focus through messages up arrow or key down arrow key"

Looks like slack is doing a bunch of tree stylings and mutations that mess with our insertion processing code. The insertions queue for the listitem container contains both redundant nodes, and unparented nodes. Some combination of this is causing us to reinsert children in the wrong order.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1682692 - (re)insert child after previous sibling, not previous insertion candidate. r?Jamie!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d61fef74272
(re)insert child after previous sibling, not previous insertion candidate. r=Jamie

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4d61fef74272

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 9193386 [details]
Bug 1682692 - (re)insert child after previous sibling, not previous insertion candidate. r?Jamie!

Beta/Release Uplift Approval Request

• User impact if declined: Hangs when opening the keyboard shortcuts lists in the Slack Help menu, other weird element order errors under certain circumstances.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1681072
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Corrects tree ordering in specific circumstances and is well tested.
• String changes made/needed: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193386 [details]
Bug 1682692 - (re)insert child after previous sibling, not previous insertion candidate. r?Jamie!

Approved for 85.0b4.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ce312f8228c