Closed Bug 1682712 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26913 - Canvas-WCG: Update names to reflect the specification

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26913 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26913
Details from upstream follow.

b'Christopher Cameron <ccameron@chromium.org>' wrote:

Canvas-WCG: Update names to reflect the specification

Change "p3" color space to "display-p3". This is the name used in the
specification and in the CSS color level 4 specification (which is
shipping on Safari). Of note is that is that the color gamut media
queries use "p3" instead of "display-p3". This could be intentional
(reflecting the p3 primaries common to DCI P3 and Display P3), or may
be accidental.

Change ImageDataColorSettings to ImageDataSettings. Right now all of
the settings are for color, but the spec doesn't put color in the name
because of future plans to add other settings (like premultiplied
alpha).

The largest remaining inconsistency is that "pixelFormat" versus
"storageFormat" and "uint8" versus "unorm8".

TBR=fserb
Bug: 1083693
Change-Id: I8e6d476a17fd2fca8da6b7901bb1098253a61559

Reviewed-on: https://chromium-review.googlesource.com/2594269
WPT-Export-Revision: e317f9cdf439d096c6ac3f42531a5e11acc0469f

PR 26913 applied with additional changes from upstream: 0fb69997a8b5154bf39ba3ffa586c2aa25442da8, e4a09698065feadbad40a6ede4ac3341bf8cc466
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 22 subtests

Status Summary

Firefox

OK : 2
PASS: 6
FAIL: 26

Chrome

OK : 2
PASS: 6
FAIL: 26

Safari

OK : 2
PASS: 6
FAIL: 26

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/manual/wide-gamut-canvas/canvas-createPutGetImageData-colorManaged.html
Test color managed cretateImageData: {srgb, uint8} -> {srgb, uint8}: FAIL (Chrome: FAIL, Safari: FAIL)
Test color managed cretateImageData: {srgb, float16} -> {srgb, float32}: FAIL (Chrome: FAIL, Safari: FAIL)
Test color managed getImageData: {srgb, uint8} -> {srgb, uint8}: FAIL (Chrome: FAIL, Safari: FAIL)
Test color managed getImageData: {srgb, float16} -> {srgb, float32}: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/manual/wide-gamut-canvas/imageData-colorManagedBehavior.html
Test createImageData(width, height) from SRGB canvas : FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height) from e-SRGB canvas : FAIL (Chrome: FAIL, Safari: FAIL)
Test getImageData(sx, sy, sw, sh) from SRGB canvas : FAIL (Chrome: FAIL, Safari: FAIL)
Test getImageData(sx, sy, sw, sh) from e-SRGB canvas : FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): e-SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): e-SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test putImageData(imagedata, dx, dy): e-SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): e-SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): e-SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(imagedata): e-SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): e-SRGB canvas, SRGB U8 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): e-SRGB canvas, e-SRGB U16 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)
Test createImageData(width, height, imageDataSettings): e-SRGB canvas, e-SRGB F32 ImageData: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fb8f703fe7a
[wpt PR 26913] - Canvas-WCG: Update names to reflect the specification, a=testonly
https://hg.mozilla.org/integration/autoland/rev/af1221f6f8c2
[wpt PR 26913] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9fb8f703fe7a
https://hg.mozilla.org/mozilla-central/rev/af1221f6f8c2

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.