Closed Bug 1682762 Opened 3 years ago Closed 3 years ago

TypeError: Object of type bytes is not JSON serializable when running ./mach wpt

Categories

(Testing :: web-platform-tests, defect)

Default
defect

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch patch?Splinter Review

When running ./mach wpt path/to/reftest I get:

TypeError: Object of type bytes is not JSON serializable

  File "/home/emilio/src/moz/gecko-3/testing/web-platform/mach_commands.py", line 502, in run_wpt
    return self.run_web_platform_tests(**params)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/mach_commands.py", line 492, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/mach_commands_base.py", line 61, in run
    result = wptrunner.start(**kwargs)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py", line 409, in start
    rv = not run_tests(**kwargs) or logged_critical.has_log
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py", line 224, in run_tests
    with env.TestEnvironment(test_paths,
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptrunner/wptrunner/environment.py", line 84, in __enter__
    self.stash.__enter__()
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/stash.py", line 47, in __enter__
    store_env_config(self.address, self.authkey)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/stash.py", line 66, in store_env_config
    os.environ["WPT_STASH_CONFIG"] = json.dumps((address, authkey.decode("ascii")))
  File "/usr/lib64/python3.9/json/__init__.py", line 231, in dumps
    return _default_encoder.encode(obj)
  File "/usr/lib64/python3.9/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/lib64/python3.9/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/lib64/python3.9/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '

The attached patch seems to allow me to run the test, but there are a lot of other errors like:

WARNING:root:Warning in source loading: /home/emilio/src/moz/gecko-3/testing/web-platform/tests/websockets/handlers/stash_responder_wsh.py: Error in sourcing handler:Traceback (most recent call last):
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/third_party/pywebsocket3/mod_pywebsocket/dispatch.py", line 144, in _source_handler_file
    exec(handler_definition, global_dic) # yapf: disable
  File "<string>", line 9, in <module>
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/stash.py", line 131, in __init__
    self._get_proxy(address, authkey)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/stash.py", line 150, in _get_proxy
    manager.connect()
  File "/usr/lib64/python3.9/multiprocessing/managers.py", line 522, in connect
    conn = Client(self._address, authkey=self._authkey)
  File "/usr/lib64/python3.9/multiprocessing/connection.py", line 507, in Client
    c = SocketClient(address)
  File "/usr/lib64/python3.9/multiprocessing/connection.py", line 635, in SocketClient
    s.connect(address)
FileNotFoundError: [Errno 2] No such file or directory
Flags: needinfo?(james)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2f341c6d43c
Handle byte addresses in stash server. r=jgraham
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26976 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR was closed without merging
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: