1682808 - Make the languageStatusButton in composer themable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

In composer, the languageStatusButton to change the spellcheck language uses the native button appearance:

• On Mac is absolutely no feedback visible. Like it would be only text.
• On Linux when hovering, depending of the Linux theme, the button has white text on white background. And the button is a bit tall which make the whole status bar tall.
• On Windows with the dark TB theme the hover is almost not visible.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1682808-languageStatusButton-themeable.patch

Using the toolbarbutton-1 class fixes the issue.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9193461 [details] [diff] [review]
1682808-languageStatusButton-themeable.patch

Review of attachment 9193461 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

::: mail/themes/shared/mail/messengercompose.css
@@ +1010,5 @@
>  }
> +
> +#languageStatusButton {
> +  margin-block: 1px;
> +  padding-block: 0;

nit: can we add the height: 22px; attribute here in the shared file, and only have the 18px variation in the macos file?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #2)

nit: can we add the height: 22px; attribute here in the shared file, and
only have the 18px variation in the macos file?

I like to let it like this. First we don't have to redefine it in the platform. And second, like this it's clear there are platform dependent variations. When it's in shared I'd suppose change the value here changes it everywhere.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a7c5ceb9cb95
Make the languageStatusButton in composer themable. r=aleca

Comment 5

[Thomas D. (:thomas8)]

Awesome, thank you Richard!

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9193461 [details] [diff] [review]
1682808-languageStatusButton-themeable.patch

[Approval Request Comment]
User impact if declined: on some platforms and themes invisible fuctionality
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1682808-languageStatusButton-themeable-ESR.patch

[Approval Request Comment]
User impact if declined: on some platforms and themes invisible fuctionality
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9193461 [details] [diff] [review]
1682808-languageStatusButton-themeable.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 85.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/52bcdcbd2a60

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9193717 [details] [diff] [review]
1682808-languageStatusButton-themeable-ESR.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/91f27dd3c19b