1682827 - Incomplete page ranges can be introduced in the new Print modal

Status: RESOLVED WORKSFORME

(Toolkit :: Printing, defect)

Description

[Vlad Lucaci, Desktop QA (:vlucaci)]

Attachment: negative values.JPG

Affected versions

• 85.0b2(20201215185920)
• 86.0a1(20201215213427)

Affected platforms

• Win10x64
• Ubuntu 18.04x64
• macOS 10.15.7

Steps to reproduce

1. Launch FF.
2. Go to any random long page.
3. Press CTRL+P(new modal)
4. Go to Pages and select Custom.
5. Input the following value: 1-3,-4,5-6,-7
6. Print

Expected result

• Ranges introduced should be valid.

Actual result

• Values can be set as negative/incomplete.

Suggested Severity

• Since this issue does only print the page number within the corrupted string (eg: -8) and is just an UI problem, I would still consider it an S3, since it does also happen on every OS.

Regression range

• I tried to search for a regression since custom range was introduced but was met with this error (attachment provided)

Additional notes

• A prompt or message should be introduced stating that "invalid page ranges can not be selected"
  Issue screenshot: https://drive.google.com/file/d/1jrPMwh0JHk1nBbKdo2ovVXDifYN7zuGp/view?usp=sharing

Comment 1

[Emma Malysz]

This is the intended behavior for the custom page range and matches Chrome/Edge behavior.

I'm going to close this bug, unless Aaron feels strongly about changing this behavior.

For clarity:
If no number proceeds the dash, we print page 1 to the number specified after the dash. (i.e. "-2" will print pages 1, 2)
If no number follows the dash, we print pages from the number specified before the dash to the final page (i.e. with a 3 page document, "2-" will print pages 2,3)
If no numbers surround the dash, we will print all the pages.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Moving things to 88, cause we're mostly on Proton these days…