Closed Bug 1682871 Opened 3 years ago Closed 4 months ago

Check behaviour of nsNavHistoryResultNode::GetTags

Categories

(Toolkit :: Places, task, P3)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: sg, Unassigned)

References

Details

Attachments

(1 file)

Bug 1682871 - Use StringJoin(Append) in nsNavHistoryResultNode::GetTags. r=mak
47 bytes, text/x-phabricator-request
Details | Review

When introducing the new StringJoin function in Bug 1583109, I scanned the codebase for possible uses of that function, and one such place seems to be nsNavHistoryResultNode::GetTags. However, I wasn't sure if the existing behaviour there is like intended, around the use of the void flag of mTags. I'll attach a draft patch to clarify this.

Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Assignee: sgiesecke → nobody
Status: ASSIGNED → NEW

we don't fetch and join tags here anymore, so I think this is wfm.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: