1682917 - No Topic or text in Chat channels

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[WaltS48 [:walts48]]

Created IRC chat account for FreeNode.
Joined some channels.

No Topics or typed text appeared in the conversation area.

Topics and typed text should appear.

Error Console shows.

Uncaught
Exception
​
columnNumber: 0
​
data: null
​
filename: "chrome://chat/content/conversation-browser.js"
​
lineNumber: 441
​
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​
message: "Cannot modify properties of a WrappedNative"
​
name: "NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN"
​
result: 2153185332
​
stack: "set isActive@chrome://chat/content/conversation-browser.js:441:7\nswitchingToPanel@chrome://messenger/content/chat/chat-conversation.js:1629:7\n_onTabActivated@chrome://messenger/content/chat/chat-messenger.js:1284:16\n_onWindowActivated@chrome://messenger/content/chat/chat-messenger.js:289:19\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
conversation-browser.js:441
set isActive chrome://chat/content/conversation-browser.js:441
switchingToPanel chrome://messenger/content/chat/chat-conversation.js:1629
_onTabActivated chrome://messenger/content/chat/chat-messenger.js:1284
_onWindowActivated chrome://messenger/content/chat/chat-messenger.js:289
13:20:22.128 Unused mode parameters: #firefox-unregistered irc.jsm:617

Comment 1

[Magnus Melin [:mkmelin]]

This is from https://hg.mozilla.org/mozilla-central/rev/6ef67464ede709855187d7d8a997d436bdb1ce2b- bug 1635914.
docShell.isActive doesn't exist anymore

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1682917_isactive.patch

conversation-browser inherits browser

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9193592 [details] [diff] [review]
bug1682917_isactive.patch

Review of attachment 9193592 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, sorry, should've double-checked whether this affected tb. r=me

Comment 4

[Magnus Melin [:mkmelin]]

Thx!

Comment 5

[Wayne Mery (:wsmwk)]

Is a blocker for beta, that we should rebuild the release with the patch?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0be8d1e01a3c
adjust for bug 1635914 - docshell.isActive doesn't exist anymore. r=emilio

Comment 7

[Geoff Lankow (:darktrojan)]

Magnus, this patch didn't have a user name. I've seen one or two others with the same problem. Might want to check your config.

Comment 8

[Magnus Melin [:mkmelin]]

Super strange. I have the patch I believe I uploaded, and it has the right headers. I wonder if bugzilla stripped it somehow. I'll try to re-upload it now and see what happens.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: (for testing) bug1682917_isactive.patch

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9193676 [details] [diff] [review]
(for testing) bug1682917_isactive.patch

Oh I know what happened. Uploaded accidentally from .hg/patches/

Comment 11

[Magnus Melin [:mkmelin]]

(In reply to Wayne Mery (:wsmwk) from comment #5)

Is a blocker for beta, that we should rebuild the release with the patch?

I think yes. Chat is pretty busted without it.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9193592 [details] [diff] [review]
bug1682917_isactive.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1635914
User impact if declined: chat busted, doesn't show any messages
Testing completed (on c-c, etc.): in todays nightly
Risk to taking this patch (and alternatives if risky): No risk, can't get much worse either.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9193592 [details] [diff] [review]
bug1682917_isactive.patch

[Triage Comment]
Approved for beta.
Will need to rebuild the candidate for 85.0b1

Comment 14

[Dave Miller [:justdave]]

https://hg.mozilla.org/releases/comm-beta/rev/922b70a605e1

Comment 15

[Dave Miller [:justdave]]

That was in Thunderbird 85.0b1 build 2. Bugherder wouldn't let me edit the comment.